This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Basic file writing API support#17
Merged
Merged
Conversation
…initial-fileio-work Conflicts: src/NativeFileSystem.js
…initial-fileio-work Conflicts: src/NativeFileSystem.js test/spec/NativeFileSystem-test.js
Member
Author
|
@njx fixed the _FileWriter bug. Ready for review. |
There was a problem hiding this comment.
It's a little odd to declare these directly on the prototype. It's more standard to just initialize them in the constructor.
Contributor
There was a problem hiding this comment.
Also, do we want to use "self", or "_this", or "that" so at line 155 it's clear what "this" is?
…ndling unit tests. Use fs.unlink() to remove files created during unit tests.
Contributor
There was a problem hiding this comment.
You should handle the case here where options.create is true, options.exclusive is false, and the file does exist.
Member
Author
There was a problem hiding this comment.
Ah, thanks. Will do.
chrisbank
added a commit
that referenced
this pull request
Dec 17, 2011
Basic file writing API support
Janpot
pushed a commit
to Janpot/brackets
that referenced
this pull request
Jul 16, 2013
Add livedevelopment with debugger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimum API for overwriting existing files:
// overwrite 'log.txt' with new content
directoryEntry.getFile('log.txt', {create: false}, function(fileEntry) {
}, errorHandler);
@njx Still buggy. _FileWriter.write() is called with this === window. Need some debugging help tomorrow morning.