-
Notifications
You must be signed in to change notification settings - Fork 674
SMQ-1672 - Add asymmetric key authentication #3228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felixgateru
wants to merge
6
commits into
absmach:main
Choose a base branch
from
felixgateru:smq1672-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e30dece to
479b267
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3228 +/- ##
===========================================
+ Coverage 39.59% 50.75% +11.15%
===========================================
Files 318 165 -153
Lines 40152 25684 -14468
===========================================
- Hits 15898 13035 -2863
+ Misses 23336 11931 -11405
+ Partials 918 718 -200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e321253 to
b487ba5
Compare
Collaborator
|
@arvindh123 Please review. |
791be29 to
783c692
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
783c692 to
8ebb173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it replaces symmetric key auth centered authentication with asymmetric per service based authentication.
What does this do?
New Features:
Enhancements:
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, tests have been updated
Did you document any new/modified feature?
Yes, in code documentation is included
Notes
sequenceDiagram participant Client participant JWKSAuthn as "JWKS AuthN Module" participant AuthService participant JWKS_EP as "JWKS HTTP Endpoint" Client->>JWKSAuthn: Send JWT for authentication JWKSAuthn->>JWKS_EP: GET /.well-known/jwks.json JWKS_EP->>AuthService: RetrieveJWKS() AuthService->>JWKS_EP: JWKS response JWKS_EP->>JWKSAuthn: JWKS keys JWKSAuthn->>Client: Validate JWT and respond