Skip to content

update ArrayInterface v7#42

Merged
YingboMa merged 5 commits intoSciML:masterfrom
ChrisRackauckas:arrayinterface
Feb 20, 2023
Merged

update ArrayInterface v7#42
YingboMa merged 5 commits intoSciML:masterfrom
ChrisRackauckas:arrayinterface

Conversation

@ChrisRackauckas
Copy link
Copy Markdown
Member

No description provided.

@YingboMa
Copy link
Copy Markdown
Member

The test failure is real.

Comment thread Project.toml Outdated
@chriselrod chriselrod closed this Feb 20, 2023
@chriselrod chriselrod reopened this Feb 20, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #42 (7cec08a) into master (d344175) will increase coverage by 0.39%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   92.96%   93.35%   +0.39%     
==========================================
  Files           1        1              
  Lines         256      256              
==========================================
+ Hits          238      239       +1     
+ Misses         18       17       -1     
Impacted Files Coverage Δ
src/FastBroadcast.jl 93.35% <100.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chriselrod
Copy link
Copy Markdown
Collaborator

Julia master has had a regression resulting in allocations.
Would be great if someone reported that.

Otherwise, I don't think we should hold up this PR because of that.
Although, the integration tests are still running as of writing this comment.

@YingboMa YingboMa merged commit be489a4 into SciML:master Feb 20, 2023
@ChrisRackauckas ChrisRackauckas deleted the arrayinterface branch February 20, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants