Skip to content

Add tests for packs dependencies #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blag merged 3 commits into from
Sep 27, 2019
Merged

Add tests for packs dependencies #179

blag merged 3 commits into from
Sep 27, 2019

Conversation

@blag
Copy link
Contributor

@blag blag commented Sep 19, 2019 •
edited
Loading

End-to-end tests for StackStorm/st2#4769:

  • Successfully install pack with dependencies
  • PackX with version 2.0 is already installed. User is trying to install PackY which requires PackX with version 1.x only.
  • PackX with version 1.0 is already installed. User is trying to install PackY which requires PackX with version 2.0 or above.
  • User wants to install PackY which requires PackA and PackB. PackA requires PackX 2.0 and PackB requires PackX 1.x.
  • Successfully linearize dependency list and install all dependencies of dependencies

@blag blag force-pushed the test-install-dependencies branch from a7f6e6e to 24c438d Compare September 19, 2019 08:42
@blag blag force-pushed the test-install-dependencies branch from 24c438d to cf80daf Compare September 19, 2019 23:08
@blag blag mentioned this pull request Sep 20, 2019
Merged
arm4b
arm4b approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Good call on taking special care about e2e tests for this important feature

@blag blag requested a review from m4dcoder September 27, 2019 18:11
m4dcoder
m4dcoder approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your diligence.

@blag blag merged commit aaec568 into master Sep 27, 2019
@blag blag deleted the test-install-dependencies branch September 27, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m4dcoder m4dcoder m4dcoder approved these changes

+1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blag @arm4b @m4dcoder