Remove EL6 support #4984
Remove EL6 support #4984
Conversation
CHANGELOG.rst
Outdated
| Added | ||
| ~~~~~ | ||
| * EL6 deprecation. Removed building of EL6 RPMs and associated jobs | ||
| Contributed by Amanda McGuinness (@amanda11 Ammeon Solutions) |
There was a problem hiding this comment.
This fits into Changed sub-category under the Changelog. Please take a look at examples from the previous release. Also please try to format this changelog message based on those examples.
There was a problem hiding this comment.
Sorry - didn't see the different sub-sections.
I see in 3.2.0 there actually was a Removed sub-category with "Removed Ubuntu 14.04 from test matrix #4897" in it.
Would you prefer it in Changed or Removed?
There was a problem hiding this comment.
Yes absolutely, Removed is even better 👍
Didn't know we had that section. Thanks for noticing that!
st2actions/bin/runners.sh
Outdated
| else | ||
| # Old debians, redhats and centos, amazon etc | ||
| # Old debians, amazon etc | ||
| sv=sysv |
There was a problem hiding this comment.
Good that you found this file!
EL6 was the last platform with sysv init system which relies on /etc/init.d/ service startup files. All OS systems we support right now have systemd only.
Please try to cleanup this file based on that information, I'll help where I can.
| # Build & Test st2 packages | ||
| packages: | ||
| parallelism: 5 | ||
| parallelism: 4 |
| cp packaging/rpm/$(COMPONENTS).spec $(RPM_SPECS_DIR)/ | ||
| cd $(RPM_SPECS_DIR) && rpmbuild --clean --rmsource -ba $(COMPONENTS).spec | ||
|
|
||
| .PHONY: rhel-rpm |
There was a problem hiding this comment.
Just FYI the rpm/deb logic in the Makefiles of st2 repository is really outdated and unused code we're guilty to remove before.
All packaging happens in https://github.com/stackstorm/st2-packages
|
Given comment about init.d then there is a python file that checks whether it’s systemd , upstart or sysv and complains if it’s none of those.
Shall I update that as well to remove the allowance of sysv?
|
It was runners.sh that also mentioned sysv. So I've updated that - but I'm not sure if its used, as the st2-packages/runners.sh seems to be what is installed - but that still mentions sysv - so not sure if there's a separate issue raised for updating st2-packages/runners.sh to remove the sysv support. |
|
Yeah, I will handle st2-packages separately in another PR, per StackStorm/community#39 |
| elif command -v service > /dev/null 2>&1; then | ||
| service $svcname $action | ||
| elif [ -x /etc/init.d/${1} ]; then | ||
| /etc/init.d/$svcname $action |
arm4b
left a comment
There was a problem hiding this comment.
Looks good!
Thanks for removing EL6 in the st2 repo!
EL6 is being deprecated. Remove running of builds in EL6.
Remove rhel-rpm in Makefiles, and keep the rpm for EL7 and above. I was a bit confused with the name rhel-rpm - it seemed to just use the el6 specs - and so I was presuming it was no-longer required - but would need confirmation.