Update action_views.py

Author: David Meu

st2api/st2api/controllers/v1/action_views.py

@@ -50,6 +50,18 @@ def _get_action_by_id(id):
             LOG.exception(msg)
             abort(http_client.NOT_FOUND, msg)
 
+    @staticmethod
+    def _get_action_by_ref(ref):
+        try:
+            action_db = Action.get_by_ref(ref)
+            if not action_db:
+                raise ValueError('Referenced action "%s" doesnt exist' % (ref))
+            return action_db
+        except Exception as e:
+            msg = 'Database lookup for ref="%s" resulted in exception. %s' % (ref, e)
+            LOG.exception(msg)
+            abort(http_client.NOT_FOUND, msg)
+
     @staticmethod
     def _get_runner_by_id(id):
         try:
@@ -70,18 +82,21 @@ def _get_runner_by_name(name):
 
 
 class ParametersViewController(object):
-    def get_one(self, action_id, requester_user):
-        return self._get_one(action_id, requester_user=requester_user)
+    def get_one(self, ref_or_id, requester_user):
+        return self._get_one(ref_or_id, requester_user=requester_user)
 
     @staticmethod
-    def _get_one(action_id, requester_user):
+    def _get_one(ref_or_id, requester_user):
         """
         List merged action & runner parameters by action id.
 
         Handle:
             GET /actions/views/parameters/1
         """
-        action_db = LookupUtils._get_action_by_id(action_id)
+        if ResourceReference.is_resource_reference(ref_or_id):
+            action_db = LookupUtils._get_action_by_ref(ref_or_id)
+        else:
+            action_db = LookupUtils._get_action_by_id(ref_or_id)
 
         permission_type = PermissionType.ACTION_VIEW
         rbac_utils = get_rbac_backend().get_utils_class()

st2api/tests/unit/controllers/v1/test_action_views.py

@@ -199,7 +199,7 @@ class ActionViewsParametersControllerTestCase(FunctionalTest):
     @mock.patch.object(
         action_validator, "validate_action", mock.MagicMock(return_value=True)
     )
-    def test_get_one(self):
+    def test_get_one_by_id(self):
         post_resp = self.app.post_json("/v1/actions", ACTION_1)
         action_id = post_resp.json["id"]
         try:
@@ -208,6 +208,18 @@ def test_get_one(self):
         finally:
             self.app.delete("/v1/actions/%s" % action_id)
 
+    @mock.patch.object(
+        action_validator, "validate_action", mock.MagicMock(return_value=True)
+    )
+    def test_get_one_by_ref(self):
+        post_resp = self.app.post_json("/v1/actions", ACTION_1)
+        action_ref = post_resp.json["ref"]
+        try:
+            get_resp = self.app.get("/v1/actions/views/parameters/%s" % action_ref)
+            self.assertEqual(get_resp.status_int, 200)
+        finally:
+            self.app.delete("/v1/actions/%s" % action_ref)
+
 
 class ActionEntryPointViewControllerTestCase(FunctionalTest):
     @mock.patch.object(