Treat KYC DENIED status as final decision with no action button (master)#2116
Merged
Conversation
…denials When Didit (KycStatus.REJECTED) or Rain (RainApplicationStatus.DENIED) KYC reaches a final denied decision, the first activation step no longer renders an action button. These outcomes cannot be manually overridden or resubmitted, so the previous "Contact support" (Rain) and "Retry KYC" (Didit) buttons were misleading dead ends. - getKYCButtonText: Rain DENIED returns no button (LOCKED/CANCELED keep "Contact support" since support can still assist with those). - isRainKYCButtonDisabled: DENIED has no actionable onPress. - getStepButtonText / isStepButtonDisabled: Didit REJECTED returns no button and no onPress. Bridge endorsement REVOKED still allows "Retry KYC". - getStepDescription: Didit REJECTED fallback no longer promises a retry. - handleRainKYCPress: drop the now-unreachable DENIED -> Intercom branch. https://claude.ai/code/session_01S2muieprRUo3BGSh8yKBtR (cherry picked from commit a87901e)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes the KYC final-decision change from
qa(#2115) tomastervia cherry-pick of commita87901e.On
/card/activate, the first step ("Complete KYC") now renders no action button when KYC reaches a final denied decision, for both providers:DENIEDREJECTEDThese are final decisions that cannot be manually overridden or resubmitted, so both buttons were misleading dead ends.
Key Changes (
hooks/useCardSteps/)getKYCButtonText: RainDENIEDreturns no button text (LOCKED/CANCELEDkeep "Contact support" since support can still assist with those).isRainKYCButtonDisabled:DENIEDnow has no actionableonPress.getStepButtonText: DiditREJECTEDreturns no button text.isStepButtonDisabled: DiditREJECTEDhas noonPress.getStepDescription: the DiditREJECTEDfallback no longer says "Please try again with a valid ID".useCardSteps(handleRainKYCPress): dropped the now-unreachableDENIED → Intercombranch.Left untouched
LOCKED/CANCELEDkeep "Contact support" — their copy ("on hold" / "start over") indicates support can still help; they aren't final denials.REVOKEDstill shows "Retry KYC" — a legitimately retryable state.Notes
a87901e(merged toqain Treat KYC DENIED status as final decision with no action button #2115). The cherry-pick applied cleanly ontomaster.tsc --noEmitclean for the changed files; ESLint passes on both files.https://claude.ai/code/session_01S2muieprRUo3BGSh8yKBtR
Generated by Claude Code