From 7bddddfee17b6b1f67d1b7f28edafb49e73e1b4c Mon Sep 17 00:00:00 2001 From: "gc.zhu" Date: Mon, 15 May 2023 11:25:48 +0800 Subject: [PATCH 1/7] handle relative path --- .../backpack-addons/babelIncludePrefixes.js | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/packages/react-scripts/backpack-addons/babelIncludePrefixes.js b/packages/react-scripts/backpack-addons/babelIncludePrefixes.js index 315d34accf7..224fa966f57 100644 --- a/packages/react-scripts/backpack-addons/babelIncludePrefixes.js +++ b/packages/react-scripts/backpack-addons/babelIncludePrefixes.js @@ -1,12 +1,19 @@ -"use strict"; +'use strict'; -const paths = require("../config/paths"); +const paths = require('../config/paths'); +const path = require('path'); const appPackageJson = require(paths.appPackageJson); -const bpkReactScriptsConfig = appPackageJson["backpack-react-scripts"] || {}; +const bpkReactScriptsConfig = appPackageJson['backpack-react-scripts'] || {}; const customModuleRegexes = bpkReactScriptsConfig.babelIncludePrefixes - ? bpkReactScriptsConfig.babelIncludePrefixes.map( - (prefix) => new RegExp(`node_modules[\\/]${prefix}`) - ) + ? bpkReactScriptsConfig.babelIncludePrefixes.map(prefix => { + if (prefix && (prefix.startsWith('.') || prefix.startsWith('/'))) { + // if the prefixes starts with '.', '..' or '/', likes '../common' + // it means is the relative path which doesn't need to be in the node_modules folder + console.log(path.resolve(paths.appPath, prefix)); + return path.resolve(paths.appPath, prefix); + } + return new RegExp(`node_modules[\\/]${prefix}`); + }) : []; // Backpack / saddlebag node module regexes From 61cad5151f6035e020f4fa28b7f8cddeb322630f Mon Sep 17 00:00:00 2001 From: "gc.zhu" Date: Tue, 16 May 2023 12:01:30 +0800 Subject: [PATCH 2/7] remove console.log --- packages/react-scripts/backpack-addons/babelIncludePrefixes.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react-scripts/backpack-addons/babelIncludePrefixes.js b/packages/react-scripts/backpack-addons/babelIncludePrefixes.js index 224fa966f57..ade3eac8ad5 100644 --- a/packages/react-scripts/backpack-addons/babelIncludePrefixes.js +++ b/packages/react-scripts/backpack-addons/babelIncludePrefixes.js @@ -9,7 +9,6 @@ const customModuleRegexes = bpkReactScriptsConfig.babelIncludePrefixes if (prefix && (prefix.startsWith('.') || prefix.startsWith('/'))) { // if the prefixes starts with '.', '..' or '/', likes '../common' // it means is the relative path which doesn't need to be in the node_modules folder - console.log(path.resolve(paths.appPath, prefix)); return path.resolve(paths.appPath, prefix); } return new RegExp(`node_modules[\\/]${prefix}`); From 6701d9d70a3d9f152a2c55b5def81195c6e9cb6e Mon Sep 17 00:00:00 2001 From: "gc.zhu" Date: Tue, 6 Jun 2023 10:13:07 +0800 Subject: [PATCH 3/7] handle relative path --- packages/react-scripts/CHANGELOG.md | 4 +++ packages/react-scripts/README.md | 2 +- .../react-scripts/backpack-addons/README.md | 28 +++++++++---------- .../backpack-addons/babelIncludePrefixes.js | 6 ++-- 4 files changed, 22 insertions(+), 18 deletions(-) diff --git a/packages/react-scripts/CHANGELOG.md b/packages/react-scripts/CHANGELOG.md index e9f3da72fc4..6a8728f1163 100644 --- a/packages/react-scripts/CHANGELOG.md +++ b/packages/react-scripts/CHANGELOG.md @@ -1,5 +1,9 @@ # `backpack-react-scripts` Change Log +## 10.2.1 + +- Identify relative path in `babelIncludePrefixes` + ## 10.2.0 - Disable `loadable` in CSR build diff --git a/packages/react-scripts/README.md b/packages/react-scripts/README.md index 7a401e4a7a4..dbea2fae2ef 100644 --- a/packages/react-scripts/README.md +++ b/packages/react-scripts/README.md @@ -27,7 +27,7 @@ npm start - **`css.html` & `js.html`**: New files in the `build/` output folder. These are html partials that include `