Skip to content

Commit 9defbf0

Browse files
committed
Code cleanup.
1 parent d35c268 commit 9defbf0

4 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/Spe/Core/Settings/ApplicationSettings.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,7 @@ public static ApplicationSettings GetInstance(string applicationName, bool perso
156156
ApplicationSettings instance = null;
157157
lock (instances)
158158
{
159-
if (instances.ContainsKey(settingsPath))
160-
{
161-
instance = instances[settingsPath];
162-
}
159+
instances.TryGetValue(settingsPath, out instance) ;
163160
if (instance == null || !instance.Loaded)
164161
{
165162
instance = new ApplicationSettings(applicationName, personalizedSettings);

src/Spe/Core/Settings/Authorization/ScriptItemSecurityEventHandler.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ public void OnEvent(object sender, EventArgs args)
4848
}
4949
}
5050

51-
5251
if (!SessionElevationManager.IsSessionTokenElevated(ApplicationNames.ItemSave))
5352
{
5453
SessionElevationErrors.OperationRequiresElevation();

src/Spe/Core/Settings/Authorization/SessionElevationManager.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ static SessionElevationManager()
5757

5858
internal static TokenDefinition GetToken(string appName)
5959
{
60-
return Tokens.ContainsKey(appName) ? Tokens[appName] : Tokens["Default"];
60+
if (Tokens.TryGetValue(appName, out var token)) return token;
61+
return Tokens["Default"];
6162
}
6263

6364
public static bool IsSessionTokenElevated(string appName)

src/Spe/Core/Settings/Authorization/WebServiceSettings.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,13 @@ namespace Spe.Core.Settings.Authorization
1111
{
1212
public static class WebServiceSettings
1313
{
14-
1514
private class ServiceState
1615
{
1716
public bool Enabled { get; set; }
1817
public bool RequireSecureConnection { get; set; }
1918
}
2019

21-
private static Dictionary<string,ServiceState> services = new Dictionary<string,ServiceState>();
20+
private static readonly Dictionary<string,ServiceState> services = new Dictionary<string,ServiceState>();
2221

2322
public const string ServiceRestfulv1 = "restfulv1";
2423
public const string ServiceRestfulv2 = "restfulv2";
@@ -66,7 +65,7 @@ static WebServiceSettings()
6665

6766
public static bool IsEnabled(string serviceName)
6867
{
69-
if (!services.Keys.Contains(serviceName))
68+
if (!services.ContainsKey(serviceName))
7069
{
7170
return false;
7271
}

0 commit comments

Comments
 (0)