Skip to content

Fix GDN/KDA bugs, require CUDA kernels, add cache-aware tests #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tscholak merged 9 commits into from
Jan 19, 2026
Merged

Fix GDN/KDA bugs, require CUDA kernels, add cache-aware tests #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cd7f314
Require CUDA kernels with no silent fallbacks
tscholak Jan 17, 2026
9af693c
Fix GDN chunk mode to use initial_state from cache
tscholak Jan 17, 2026
fe64f6c
Add extended cache tests for GDN and KDA equivalence
tscholak Jan 17, 2026
f6989c6
Merge cache and non-cache equivalence tests with proper Apriel2Cache
tscholak Jan 17, 2026
05cdfdd
Refactor mixer tests and fix KDA mode selection
tscholak Jan 17, 2026
66f4696
Remove redundant test_causal_conv1d.py
tscholak Jan 17, 2026
24f6133
Consolidate cache.py into modeling_apriel2.py
tscholak Jan 17, 2026
f25c24e
Enable bf16 tests and fix dtype handling
tscholak Jan 17, 2026
5669a35
Refactor test_mixer_equivalence.py: extract config fixtures and helpers
tscholak Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
406 changes: 0 additions & 406 deletions fast_llm_external_models/apriel2/cache.py
View file
Open in desktop

This file was deleted.

856 changes: 510 additions & 346 deletions fast_llm_external_models/apriel2/modeling_apriel2.py
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions fast_llm_external_models/tests/test_apriel2/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import torch
from transformers import LlavaConfig, LlavaForConditionalGeneration, MistralConfig

from fast_llm_external_models.apriel2.cache import _AttentionCache, _SSMCache
from fast_llm_external_models.apriel2.modeling_apriel2 import _AttentionCache, _SSMCache


# Register custom marks
Expand Down Expand Up @@ -831,7 +831,7 @@ def apriel2_config_with_bias():
@pytest.fixture
def apriel2_cache(apriel2_config_tiny):
"""Create empty Apriel2Cache from tiny config."""
from fast_llm_external_models.apriel2.cache import Apriel2Cache
from fast_llm_external_models.apriel2.modeling_apriel2 import Apriel2Cache

return Apriel2Cache(apriel2_config_tiny)

Expand Down
2 changes: 1 addition & 1 deletion fast_llm_external_models/tests/test_apriel2/test_cache_apriel2_specific.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import pytest
import torch

from fast_llm_external_models.apriel2.cache import Apriel2Cache
from fast_llm_external_models.apriel2.modeling_apriel2 import Apriel2Cache

# =============================================================================
# STOCHASTIC MIXER ROUTING
Expand Down
2 changes: 1 addition & 1 deletion fast_llm_external_models/tests/test_apriel2/test_cache_contracts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import pytest
import torch

from fast_llm_external_models.apriel2.cache import Apriel2Cache, _AttentionCache
from fast_llm_external_models.apriel2.modeling_apriel2 import Apriel2Cache, _AttentionCache

# =============================================================================
# SECTION 1: FULL ATTENTION - _AttentionCache vs DynamicLayer
Expand Down
Loading
Loading