From 0ccd5243a54a11edb8e49bd3685b4ce67c4ab40c Mon Sep 17 00:00:00 2001 From: delta456 Date: Thu, 26 Sep 2024 13:01:11 +0530 Subject: [PATCH 1/2] [java]: fix decoding of line endings --- .../selenium/remote/codec/AbstractHttpResponseCodec.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java b/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java index b806dfc40935c..25a5351189598 100644 --- a/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java +++ b/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java @@ -108,12 +108,6 @@ public Response decode(HttpResponse encodedResponse) { response.setValue(content); } - if (response.getValue() instanceof String) { - // We normalise to \n because Java will translate this to \r\n - // if this is suitable on our platform, and if we have \r\n, java will - // turn this into \r\r\n, which would be Bad! - response.setValue(((String) response.getValue()).replace("\r\n", "\n")); - } if (response.getStatus() != null && response.getState() == null) { response.setState(errorCodes.toState(response.getStatus())); From 7750a13462179864068af09065e5200f1b509dc6 Mon Sep 17 00:00:00 2001 From: delta456 Date: Thu, 3 Oct 2024 14:07:42 +0530 Subject: [PATCH 2/2] format --- .../openqa/selenium/remote/codec/AbstractHttpResponseCodec.java | 1 - 1 file changed, 1 deletion(-) diff --git a/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java b/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java index 25a5351189598..78b18f76e09d3 100644 --- a/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java +++ b/java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java @@ -108,7 +108,6 @@ public Response decode(HttpResponse encodedResponse) { response.setValue(content); } - if (response.getStatus() != null && response.getState() == null) { response.setState(errorCodes.toState(response.getStatus())); } else if (response.getStatus() == null && response.getState() != null) {