From f7cce33a1cefd64713a376f187679ca140685b59 Mon Sep 17 00:00:00 2001 From: Michael Mintz Date: Thu, 7 Sep 2023 18:43:01 -0400 Subject: [PATCH 1/2] Update visibility_tests.py to verify that "_" is not overwritten Update visibility_tests.py to verify that "_" is not overwritten --- py/test/selenium/webdriver/common/visibility_tests.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/py/test/selenium/webdriver/common/visibility_tests.py b/py/test/selenium/webdriver/common/visibility_tests.py index 458bc7c2681a7..22245d3deb5e7 100644 --- a/py/test/selenium/webdriver/common/visibility_tests.py +++ b/py/test/selenium/webdriver/common/visibility_tests.py @@ -127,6 +127,17 @@ def test_should_say_element_with_zero_transform_is_visible(driver, pages): assert zero_tranform.is_displayed() is True +def test_checking_for_visibility_does_not_overwrite_underscore(driver, pages): + pages.load("cssTransform.html") + driver.execute_script("_ = 'abc123';") + zero_tranform = driver.find_element(By.ID, "zero-tranform") + underscore_1 = driver.execute_script("return _;") + zero_tranform.is_displayed() + underscore_2 = driver.execute_script("return _;") + assert underscore_1 == underscore_2 + assert underscore_2 == 'abc123' + + def test_should_say_element_is_visible_when_it_has_negative_transform_but_elementisnt_in_anegative_space(driver, pages): pages.load("cssTransform2.html") zero_tranform = driver.find_element(By.ID, "negative-percentage-transformY") From 72fa2cc7188b7880e23900deb98e255c32b94ac5 Mon Sep 17 00:00:00 2001 From: Michael Mintz Date: Thu, 7 Sep 2023 19:09:19 -0400 Subject: [PATCH 2/2] Update visibility_tests.py (Linter changes) Update visibility_tests.py (Linter changes) --- py/test/selenium/webdriver/common/visibility_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/test/selenium/webdriver/common/visibility_tests.py b/py/test/selenium/webdriver/common/visibility_tests.py index 22245d3deb5e7..95648cd1da657 100644 --- a/py/test/selenium/webdriver/common/visibility_tests.py +++ b/py/test/selenium/webdriver/common/visibility_tests.py @@ -135,7 +135,7 @@ def test_checking_for_visibility_does_not_overwrite_underscore(driver, pages): zero_tranform.is_displayed() underscore_2 = driver.execute_script("return _;") assert underscore_1 == underscore_2 - assert underscore_2 == 'abc123' + assert underscore_2 == "abc123" def test_should_say_element_is_visible_when_it_has_negative_transform_but_elementisnt_in_anegative_space(driver, pages):