example_data folder missing from Windows distribution

[smk78]

Describe the bug
The \example_data folder is not included in the Windows distribution of 6.1.0!

@jamescrake-merani has independently checked for and verified this bug.

To Reproduce
Steps to reproduce the behavior:

1. Install the 6.1.0 release on a Windows machine
2. Open a File Explorer and navigate to the installation folder
3. Observe that the \example_data folder is absent

Expected behavior
The \example_data folder should be present.

Screenshots

SasView version (please complete the following information):

• Version: 6.1.0

Operating system (please complete the following information):

• OS: Windows

Installation method (please complete the following information):

• Installed: tagged release Windows installer

Additional context
The \example_data folder is present in 6.0.1 & 6.0.0 (in v5.x and earlier it was called test). This is a bug introduced in 6.1.0.

I presume that since no one else has flagged this (eg, at the recent ICNS SasView session) it is specific to Windows, but do not have the means to check other platforms (and IDAaAS@ISIS is offline at present). It would be good to have reports from other platforms.

In the run-up to the release of 6.1.0 there was discussion about the need for/size of \example_data in the distribution, and some house-keeping was performed, but to my knowledge there was no definitive decision to remove \example_data from 6.1.0? Thus what we are likely looking at here is either an erroneous commit (though surely that would affect all platforms?) or an issue with pyinstaller?

As \example_data is referenced in the Tutorials (and likely some Help Documentation too) I am labelling this as a blocker for 6.1.1.

[krzywon]

I just looked at this and found it one level deeper in the file tree. Look in the sas directory and you should find example_data there. Regardless, we need to be sure the installation location is consistent across versions.

[llimeht]

Regardless, we need to be sure the installation location is consistent across versions.

I'd also add to that: consistency across installation methods (running from git, installing from source, from pip, from pyinstaller, from wheels, from flatpak, whatever is done on CI).

In 6.0.x example_data was under both locations on CI but only one was shipped.

Making sure all the different routes end up at the same end point is really important to development, effective testing, the CI testing being meaningful, etc. That does mean that all the resources of the sas module need to be inside the sas directory.