Fix use arm neon instructions if targeting 32-bit arm architectures only #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compilation for arm64 platforms, like Apple Silicon, because the assembly code contained in `pixman-arm-neon-asm.S` is armv7 assembly, which is not supported by arm64 compilers.
ed-asriyan
added a commit
to ed-asriyan/lottie-converter
that referenced
this pull request
May 26, 2024
Newer versions of the Android NDK use clang for compiling, which cannot compile the code contained in `pixman-arm-neon-asm.S`.
Author
|
Now this PR also fixes compilation when using clang, for example when building rlottie for Android arm32 with newer versions of the NDK, which cannot build |
|
This worked for me on mac, would be great if it could be merged |
|
To add fuel to this, I have successfully used this to build on MacOS 15.1.1 on an M1 Pro MacBook Pro and in an AARCH64 Ubuntu 22.04 VM on the same machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation for arm64 platforms that support neon instructions, like Apple Silicon, because the assembly code contained in
pixman-arm-neon-asm.Sis armv7 assembly, which is not supported by arm64 compilers.Fixes #496.