Implement Array.fromAsync

Signed-off-by: Seonghyun Kim <[email protected]>

Author: ksh8281

src/builtins/BuiltinArray.cpp

@@ -1333,29 +1333,29 @@ Value Object::call(ExecutionState& state, const Value& callee, const Value& this
 }
 
 // https://www.ecma-international.org/ecma-262/10.0/#sec-construct
-Value Object::construct(ExecutionState& state, const Value& constructor, const size_t argc, Value* argv, Object* newTarget)
+Value Object::construct(ExecutionState& state, const Value& constructor, const size_t argc, Value* argv, Optional<Object*> newTarget)
 {
     // If newTarget was not passed, let newTarget be F.
-    if (newTarget == nullptr) {
+    if (!newTarget) {
         newTarget = constructor.asObject();
     }
 
     ASSERT(constructor.isConstructor());
     ASSERT(newTarget->isConstructor());
 
-    return constructor.asPointerValue()->construct(state, argc, argv, newTarget);
+    return constructor.asPointerValue()->construct(state, argc, argv, newTarget.value());
 }
 
-void Object::callConstructor(ExecutionState& state, const Value& constructor, Object* receiver, const size_t argc, Value* argv, Object* newTarget)
+void Object::callConstructor(ExecutionState& state, const Value& constructor, Object* receiver, const size_t argc, Value* argv, Optional<Object*> newTarget)
 {
-    if (newTarget == nullptr) {
+    if (!newTarget) {
         newTarget = constructor.asObject();
     }
 
     ASSERT(constructor.isConstructor());
     ASSERT(newTarget->isConstructor());
 
-    return constructor.asPointerValue()->callConstructor(state, receiver, argc, argv, newTarget);
+    return constructor.asPointerValue()->callConstructor(state, receiver, argc, argv, newTarget.value());
 }
 
 // https://www.ecma-international.org/ecma-262/#sec-setintegritylevel

src/runtime/Object.cpp

@@ -1100,9 +1100,9 @@ class Object : public PointerValue {
     }
 
     static Value call(ExecutionState& state, const Value& callee, const Value& thisValue, const size_t argc, Value* argv);
-    static Value construct(ExecutionState& state, const Value& constructor, const size_t argc, Value* argv, Object* newTarget = nullptr);
+    static Value construct(ExecutionState& state, const Value& constructor, const size_t argc, Value* argv, Optional<Object*> newTarget = NullOption);
     // call constructor with already created object(some clients need this)
-    static void callConstructor(ExecutionState& state, const Value& constructor, Object* receiver, const size_t argc, Value* argv, Object* newTarget = nullptr);
+    static void callConstructor(ExecutionState& state, const Value& constructor, Object* receiver, const size_t argc, Value* argv, Optional<Object*> newTarget = NullOption);
 
     static bool setIntegrityLevel(ExecutionState& state, Object* O, bool isSealed);
     static bool testIntegrityLevel(ExecutionState& state, Object* O, bool isSealed);

src/runtime/Object.h

@@ -76,6 +76,8 @@ class GlobalObjectProxyObject;
 class DisposableStackObject;
 class AsyncDisposableStackObject;
 struct DisposableResourceRecord;
+struct ArrayFromAsyncRecord;
+struct ArrayFromAsyncSyncRecord;
 #if defined(ENABLE_TEMPORAL)
 class TemporalObject;
 class TemporalPlainTimeObject;
@@ -532,6 +534,16 @@ class PointerValue : public gc {
         return false;
     }
 
+    virtual bool isArrayFromAsyncRecord() const
+    {
+        return false;
+    }
+
+    virtual bool isArrayFromAsyncSyncRecord() const
+    {
+        return false;
+    }
+
 #if defined(ENABLE_INTL)
     virtual bool isIntlLocaleObject() const
     {
@@ -1009,6 +1021,18 @@ class PointerValue : public gc {
         return (AsyncDisposableStackObject*)this;
     }
 
+    ArrayFromAsyncRecord* asArrayFromAsyncRecord()
+    {
+        ASSERT(isArrayFromAsyncRecord());
+        return (ArrayFromAsyncRecord*)this;
+    }
+
+    ArrayFromAsyncSyncRecord* asArrayFromAsyncSyncRecord()
+    {
+        ASSERT(isArrayFromAsyncSyncRecord());
+        return (ArrayFromAsyncSyncRecord*)this;
+    }
+
 #if defined(ENABLE_THREADING)
     SharedArrayBufferObject* asSharedArrayBufferObject()
     {

src/runtime/PointerValue.h

@@ -232,6 +232,7 @@ namespace Escargot {
     F(forEach)                    \
     F(freeze)                     \
     F(from)                       \
+    F(fromAsync)                  \
     F(fromBase64)                 \
     F(fromCharCode)               \
     F(fromCodePoint)              \

src/runtime/StaticStrings.h

@@ -20,11 +20,6 @@
     <test id="built-ins/AbstractModuleSource/prototype/constructor"><reason>TODO</reason></test>
     <test id="built-ins/AbstractModuleSource/prototype/proto"><reason>TODO</reason></test>
     <test id="built-ins/AbstractModuleSource/throw-from-constructor"><reason>TODO</reason></test>
-    <test id="built-ins/Array/fromAsync/builtin"><reason>TODO</reason></test>
-    <test id="built-ins/Array/fromAsync/length"><reason>TODO</reason></test>
-    <test id="built-ins/Array/fromAsync/name"><reason>TODO</reason></test>
-    <test id="built-ins/Array/fromAsync/not-a-constructor"><reason>TODO</reason></test>
-    <test id="built-ins/Array/fromAsync/prop-desc"><reason>TODO</reason></test>
     <test id="built-ins/Array/prototype/join/coerced-separator-shrink"><reason>TODO</reason></test>
     <test id="built-ins/ArrayBuffer/prototype/resizable/detached-buffer"><reason>TODO</reason></test>
     <test id="built-ins/ArrayBuffer/prototype/resize/coerced-new-length-detach"><reason>TODO</reason></test>
@@ -1206,4 +1201,4 @@
     <test id="staging/sm/syntax/yield-as-identifier"><reason>TODO</reason></test>
     <test id="staging/sm/types/8.12.5-01"><reason>TODO</reason></test>
     <test id="staging/source-phase-imports/import-source-source-text-module"><reason>TODO</reason></test>
-</excludeList>
+</excludeList>