digest: enable and fix workspace-level lints

Author: tarcieri

digest/Cargo.toml

@@ -36,5 +36,8 @@ zeroize = ["dep:zeroize", "block-buffer?/zeroize"]
 alloc = []
 dev = ["blobby"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true

digest/src/block_api.rs

@@ -96,6 +96,7 @@ pub trait VariableOutputCore: UpdateCore + OutputSizeUser + BufferKindUser + Siz
 
     /// Initialize hasher state for given output size.
     ///
+    /// # Errors
     /// Returns [`InvalidOutputSize`] if `output_size` is not valid for
     /// the algorithm, e.g. if it's bigger than the [`OutputSize`]
     /// associated type.

digest/src/dev.rs

@@ -1,5 +1,7 @@
 //! Development-related functionality
 
+#![allow(clippy::missing_errors_doc)]
+
 pub use blobby;
 
 mod fixed;

digest/src/digest.rs

@@ -114,7 +114,7 @@ impl<D: FixedOutput + Default + Update + HashMarker> Digest for D {
     where
         Self: Reset,
     {
-        Reset::reset(self)
+        Reset::reset(self);
     }
 
     #[inline]
@@ -148,6 +148,7 @@ pub trait DynDigest {
     /// Retrieve result and consume boxed hasher instance
     #[cfg(feature = "alloc")]
     #[allow(clippy::boxed_local)]
+    #[must_use]
     fn finalize(mut self: Box<Self>) -> Box<[u8]> {
         let mut result = vec![0; self.output_size()];
         self.finalize_into_reset(&mut result).unwrap();
@@ -156,11 +157,13 @@ pub trait DynDigest {
 
     /// Write result into provided array and consume the hasher instance.
     ///
+    /// # Errors
     /// Returns error if buffer length is not equal to `output_size`.
     fn finalize_into(self, buf: &mut [u8]) -> Result<(), InvalidBufferSize>;
 
     /// Write result into provided array and reset the hasher instance.
     ///
+    /// # Errors
     /// Returns error if buffer length is not equal to `output_size`.
     fn finalize_into_reset(&mut self, out: &mut [u8]) -> Result<(), InvalidBufferSize>;
 

digest/src/lib.rs

@@ -6,7 +6,7 @@
     html_logo_url = "https://github.com/RustCrypto/media/6ee8e381/logo.svg",
     html_favicon_url = "https://github.com/RustCrypto/media/6ee8e381/logo.svg"
 )]
-#![warn(missing_docs, rust_2018_idioms, missing_debug_implementations)]
+#![allow(clippy::unwrap_used)] // TODO
 
 //! ## Structure
 //!

digest/src/mac.rs

@@ -36,39 +36,47 @@ pub trait Mac: OutputSizeUser + Sized {
         Self: Reset;
 
     /// Check if tag/code value is correct for the processed input.
+    ///
+    /// # Errors
+    /// Returns [`MacError`] if `tag` is not valid.
     fn verify(self, tag: &Output<Self>) -> Result<(), MacError>;
 
     /// Check if tag/code value is correct for the processed input and reset
     /// [`Mac`] instance.
+    ///
+    /// # Errors
+    /// Returns [`MacError`] if `tag` is not valid.
     fn verify_reset(&mut self, tag: &Output<Self>) -> Result<(), MacError>
     where
         Self: FixedOutputReset;
 
     /// Check truncated tag correctness using all bytes
     /// of calculated tag.
     ///
-    /// Returns `Error` if `tag` is not valid or not equal in length
-    /// to MAC's output.
+    /// # Errors
+    /// Returns [`MacError`] if `tag` is not valid or not equal in length to this MAC's output.
     fn verify_slice(self, tag: &[u8]) -> Result<(), MacError>;
 
     /// Check truncated tag correctness using all bytes
     /// of calculated tag and reset [`Mac`] instance.
     ///
-    /// Returns `Error` if `tag` is not valid or not equal in length
-    /// to MAC's output.
+    /// # Errors
+    /// Returns [`MacError`] if `tag` is not valid or not equal in length to MAC's output.
     fn verify_slice_reset(&mut self, tag: &[u8]) -> Result<(), MacError>
     where
         Self: FixedOutputReset;
 
     /// Check truncated tag correctness using left side bytes
     /// (i.e. `tag[..n]`) of calculated tag.
     ///
+    /// # Errors
     /// Returns `Error` if `tag` is not valid or empty.
     fn verify_truncated_left(self, tag: &[u8]) -> Result<(), MacError>;
 
     /// Check truncated tag correctness using right side bytes
     /// (i.e. `tag[n..]`) of calculated tag.
     ///
+    /// # Errors
     /// Returns `Error` if `tag` is not valid or empty.
     fn verify_truncated_right(self, tag: &[u8]) -> Result<(), MacError>;
 }
@@ -103,7 +111,7 @@ impl<T: Update + FixedOutput + MacMarker> Mac for T {
     where
         Self: Reset,
     {
-        Reset::reset(self)
+        Reset::reset(self);
     }
 
     #[inline]
@@ -236,7 +244,7 @@ impl<T: OutputSizeUser> Drop for CtOutput<T> {
         #[cfg(feature = "zeroize")]
         {
             use zeroize::Zeroize;
-            self.bytes.zeroize()
+            self.bytes.zeroize();
         }
     }
 }

digest/src/xof_fixed.rs

@@ -83,7 +83,7 @@ impl<T: ExtendableOutput + Reset, S: ArraySize> Reset for XofFixedWrapper<T, S>
 
 impl<T: ExtendableOutput + Update, S: ArraySize> Update for XofFixedWrapper<T, S> {
     fn update(&mut self, data: &[u8]) {
-        self.hash.update(data)
+        self.hash.update(data);
     }
 }
 

digest/tests/dummy_fixed.rs

@@ -1,3 +1,5 @@
+//! Tests against a pseudo-hash.
+
 #![cfg(feature = "block-api")]
 
 mod block_api {
@@ -13,7 +15,7 @@ mod block_api {
     };
 
     /// Core of primitive XOR hasher for testing purposes
-    #[derive(Clone, Default, Debug)]
+    #[derive(Clone, Copy, Default, Debug)]
     pub struct FixedHashCore {
         state: u64,
     }
@@ -41,7 +43,7 @@ mod block_api {
     impl UpdateCore for FixedHashCore {
         fn update_blocks(&mut self, blocks: &[Block<Self>]) {
             for block in blocks {
-                self.state ^= u64::from_le_bytes(block.0)
+                self.state ^= u64::from_le_bytes(block.0);
             }
         }
     }