x509-cert: consume the SignatureBitStringEncoding trait

Author: baloo

Cargo.lock

@@ -17,7 +17,7 @@ rust-version = "1.65"
 [dependencies]
 const-oid = { version = "0.9.2", features = ["db"] } # TODO: path = "../const-oid"
 der = { version = "0.7.5", features = ["alloc", "derive", "flagset", "oid"] }
-spki = { version = "0.7.1", features = ["alloc"] }
+spki = { version = "0.7.2", features = ["alloc"] }
 
 # optional dependencies
 arbitrary = { version = "1.3", features = ["derive"], optional = true }
@@ -28,7 +28,7 @@ signature = { version = "2.1.0", features = ["rand_core"], optional = true }
 hex-literal = "0.4"
 rand = "0.8.5"
 rsa = { version = "0.9.2", features = ["sha2"] }
-ecdsa = { version = "0.16.4", features = ["digest", "pem"] }
+ecdsa = { version = "0.16.7", features = ["digest", "pem"] }
 p256 = "0.13.0"
 rstest = "0.17"
 sha2 = { version = "0.10", features = ["oid"] }

x509-cert/Cargo.toml

@@ -3,10 +3,10 @@
 use alloc::vec;
 use core::fmt;
 use der::{asn1::BitString, referenced::OwnedToRef, Encode};
-use signature::{rand_core::CryptoRngCore, Keypair, RandomizedSigner, SignatureEncoding, Signer};
+use signature::{rand_core::CryptoRngCore, Keypair, RandomizedSigner, Signer};
 use spki::{
-    DynSignatureAlgorithmIdentifier, EncodePublicKey, SubjectPublicKeyInfoOwned,
-    SubjectPublicKeyInfoRef,
+    DynSignatureAlgorithmIdentifier, EncodePublicKey, SignatureBitStringEncoding,
+    SubjectPublicKeyInfoOwned, SubjectPublicKeyInfoRef,
 };
 
 use crate::{
@@ -421,12 +421,11 @@ pub trait Builder: Sized {
     fn build<Signature>(mut self) -> Result<Self::Output>
     where
         Self::Signer: Signer<Signature>,
-        Signature: SignatureEncoding,
+        Signature: SignatureBitStringEncoding,
     {
         let blob = self.finalize()?;
 
-        let signature = self.signer().try_sign(&blob)?;
-        let signature = BitString::from_bytes(signature.to_bytes().as_ref())?;
+        let signature = self.signer().try_sign(&blob)?.to_bitstring()?;
 
         self.assemble(signature)
     }
@@ -435,12 +434,14 @@ pub trait Builder: Sized {
     fn build_with_rng<Signature>(mut self, rng: &mut impl CryptoRngCore) -> Result<Self::Output>
     where
         Self::Signer: RandomizedSigner<Signature>,
-        Signature: SignatureEncoding,
+        Signature: SignatureBitStringEncoding,
     {
         let blob = self.finalize()?;
 
-        let signature = self.signer().try_sign_with_rng(rng, &blob)?;
-        let signature = BitString::from_bytes(signature.to_bytes().as_ref())?;
+        let signature = self
+            .signer()
+            .try_sign_with_rng(rng, &blob)?
+            .to_bitstring()?;
 
         self.assemble(signature)
     }