Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@hfeky
Copy link
Contributor

@hfeky hfeky commented May 20, 2019

@RocketChat/android

Closes #2253
Closes #2277

Changes:

  1. Fixed bottom sheets not being scrollable when the sheet is too long for the device screen. Initially one could not scroll.
  2. Fixed bottom sheets not being completely visible when the sheet is too long for the device screen.
  3. Fixed hardcoded string "+99" in ChatRoomFragment.
  4. Corrected 2 translations in Arabic language.

GIFs for the change:

Portrait:
Bottom Sheet Portrait

Landscape:
Bottom Sheet Landscape

@philipbrito
Copy link
Contributor

@HusseinElFeky Are you using the 3.4.1 app version and facing the blank chat list issue?

@hfeky
Copy link
Contributor Author

hfeky commented May 22, 2019

@filipedelimabrito Unfortunately yes, tried 3.4.1 on Play Store and 3.4.1 (latest commit) from here, on open.rocket.chat server, and no chats are showing. However there is a sneaky temporary workaround that I do to be able to chat with users. This only works for users, not channels. If you go to Directory, search for any user, and click on him, a toast will show, saying "Expected END_ARRAY but was END_OBJECT at path $.update[8].lastMessage". It will not open the chat, but if you return to the main chats list, the user you clicked on earlier will appear, and now you can chat with him. I can send you a GIF, showing that if you want. Also if by any way you need help with testing, I can help you.

Update: I have sent you a GIF, demonstrating that issue in a DM on Rocket.Chat.

@philipbrito philipbrito changed the base branch from develop to master June 2, 2019 16:32
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HusseinElFeky!
👏 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants