Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@maryambehzi
Copy link
Contributor

@maryambehzi maryambehzi commented Jan 6, 2019

@RocketChat/android

Changes:

Adds Persian language to the app

@maryambehzi maryambehzi mentioned this pull request Jan 6, 2019
@philipbrito philipbrito changed the title Fa translate [I18N] Add Persian language Jan 9, 2019
@philipbrito philipbrito added this to the 3.2.0 milestone Jan 9, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryambehzi I've added TODOs for missing translations on you PR (more precisely to the Persian language file added from you). Could you please translate those strings?

I have the following concern: Will be the placeholders work from that file? Take a look on this example:

From the default (English) string file we have
<string name="message_role_add">%1$s was set %2$s by %3$s</string>, from your file we have <string name="message_role_add">%1$s به این تغییر داده شد %2$s توسط %3$s</string>. Could you see the difference on how the placeholders (%1$s, %2$s, %3$s) are being used here?

@philipbrito philipbrito modified the milestones: 3.2.0, 3.3.0 Jan 14, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryambehzi I've made changes on this PR to make sure it will work as expected. Basically all strings with placeholders (%1$d, %2$d, %d...) was updated - with a TODO wich indicates that those needs to be translated.

If you can translate those strings please open a PR with the translations making sure that the placeholders are declared as expect (as well as the \n escape).

Feel free to join our channel for any kind of question/support.

Thank you very much!

@philipbrito philipbrito merged commit b1a0d02 into RocketChat:develop Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants