Fix DribbbleRipper to get image URLs (#2158)

* Update parsing logic for the site's new layout
* Enable test

Co-authored-by: shan <[email protected]>

Author: chiang-sh

src/main/java/com/rarchives/ripme/ripper/rippers/DribbbleRipper.java

@@ -55,39 +55,40 @@ public Document getNextPage(Document doc) throws IOException {
     @Override
     public List<String> getURLsFromPage(Document doc) {
         List<String> imageURLs = new ArrayList<>();
-        for (Element thumbLink : doc.select("a.dribbble-link")) {
-            // Resolve the absolute shot page URL
-            String shotPage = thumbLink.absUrl("href");
-            if (shotPage.isEmpty()) {
-                continue;
-            }
-
-            // Fetch the shot page
-            Document shotDoc;
-            try {
-                shotDoc = Http.url(shotPage).get();
-            } catch (IOException e) {
-                continue;
-            }
-
-            // Grab the first <img> (the full-size image) on that page
-            Element imageEl = shotDoc.selectFirst("div.shot-page-container img");
-            if (imageEl == null) {
-                continue;
-            }
-
-            // Always use absUrl so you get a complete URI or an empty string
-            String imageURL = imageEl.absUrl("src");
-            if (imageURL.isEmpty()) {
-                continue;
+        for (Element thumb : doc.select("div.shot-thumbnail-base > figure > img")) {
+            String srcset = thumb.attr("data-srcset");
+            String imageURL = getLargestImageURL(srcset);
+            if (imageURL != null) {
+                imageURLs.add(imageURL);
             }
-
-            imageURLs.add(imageURL);
         }
         return imageURLs;
     }
     @Override
     public void downloadURL(URL url, int index) {
         addURLToDownload(url, getPrefix(index));
     }
+
+    private String getLargestImageURL(String srcset) {
+        int maxWidth = 0;
+        String largestURL = null;
+
+        String[] imageURLs = srcset.split(", ");
+        for (String imageURL : imageURLs) {
+            try {
+                String[] parts = imageURL.trim().split(" ");
+                String url = parts[0];
+                String size = parts[1];
+                int width = Integer.parseInt(size.replace("w", ""));
+
+                if (width > maxWidth) {
+                    maxWidth = width;
+                    largestURL = url;
+                }
+            } catch (ArrayIndexOutOfBoundsException | NumberFormatException e) {
+                continue;
+            }
+        }
+        return largestURL;
+    }
 }

src/test/java/com/rarchives/ripme/tst/ripper/rippers/DribbbleRipperTest.java

@@ -5,12 +5,10 @@
 import java.net.URISyntaxException;
 
 import com.rarchives.ripme.ripper.rippers.DribbbleRipper;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 public class DribbbleRipperTest extends RippersTest {
     @Test
-    @Disabled("test or ripper broken")
     public void testDribbbleRip() throws IOException, URISyntaxException {
         DribbbleRipper ripper = new DribbbleRipper(new URI("https://dribbble.com/typogriff").toURL());
         testRipper(ripper);