[8.2] [MOD-10238] Training bm for SVS #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial imp of training bm introduce BM_VecSimSVSTrain class with 2 methods: Train and TrainAsync add GoogleTest to benchmarks so we can use ASSERT_* API tieredIndexMock: possible to initialize with a specific thread count add train bemchmark to CI benchmark dispatcher * make bm_files general for other algs rename svs_training_fp32 ->svs_indices_training_fp32 add to bm_files.sh * replace std::formtat only supported from gcc13 with ostringstream * format * revrt assert * intialize quantBits move svs params init to CreateTieredSVSIndex only 5 iterations * move iterawtion logic to runTrainBMIteration add compressed index bm * assert depdnding on HAVE_SVS_LVQ * sepearate non compression and compression bm * TO REVERT !!! test abort * fix if else * revrt timeoutgurard vhanges * dont pause after training to see how it affrects performance remove some prints * fix #ifdef HAVE_SVS_LVQ to #if HAVE_SVS_LVQ * use pause timers its faster * do 3 iter instread of 5 and test if results are stable * use 5 again * fix download all all script * fp16 bm remove 100K * remove 100K from fp32 * increase timeout * try bigger machine * try a bigger machine * try 2 iter move UNIT_AND_ITERATIONS and QUANT_BITS_ARGS to bm_vecsim_basics_Svs * unify bm_training_initialize_fp32.h and bm_training_initialize_fp16.h to bm_training_initialize.h define DATA_TYPE_INDEX_T in bm_svs_training_fp*.cpp remove th 10k and 50k for arm * reevet timeout to 10 fix include header for fp16 * move CreateTieredSVSParams and verifyNumThreads to svs params * revert increease machine size * change assert to log * fix * fix2 * format * rename BM_VecSimSVSTrain->BM_VecSimSVS bm_vecsim_svs_train.h->bm_vecsim_svs * remove unrelated * Modify mock_thread_pool initialization in Train benchmark * improve comment (cherry picked from commit 1a15b59)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #830 +/- ##
==========================================
- Coverage 96.97% 96.95% -0.02%
==========================================
Files 126 126
Lines 7329 7329
==========================================
- Hits 7107 7106 -1
- Misses 222 223 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenGoldberger
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #822 to 8.2