2.x: cancel upstream first, dispose worker last#5075
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Feb 6, 2017
Merged
Conversation
Codecov Report@@ Coverage Diff @@
## 2.x #5075 +/- ##
============================================
- Coverage 95.65% 95.55% -0.11%
+ Complexity 5544 5542 -2
============================================
Files 612 612
Lines 39575 39561 -14
Branches 5554 5553 -1
============================================
- Hits 37857 37803 -54
- Misses 746 771 +25
- Partials 972 987 +15
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 6, 2017
This was referenced Feb 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure the
Scheduler.Workeris disposed only afterThis may help with situations when the worker-dispose interrupts a thread that is blocked and the InterruptedException handler checks for the stream to be disposed so the exception can be safely ignored (and thus not end up in the RxJavaPlugins.onError handler to crash the app).
Related: #4863