resolved some todos

Author: eceltov

app/helpers/MetaFormats/MetaFormatHelper.php

@@ -154,7 +154,6 @@ public static function createNameToFieldDefinitionsMap(string $className): array
                 );
             }
 
-            ///TODO: add base type (PHP type of the field) validators to $requestParamData
             $formats[$fieldName] = $requestParamData;
         }
 

app/helpers/MetaFormats/MetaRequest.php

@@ -43,7 +43,6 @@ public function getParameter(string $key): mixed
      * Returns a variable provided to the presenter via POST.
      * If no key is passed, returns the entire array.
      */
-    ///TODO: how should null be handled?
     public function getPost(?string $key = null): mixed
     {
         if ($key === null) {

app/helpers/MetaFormats/RequestParamData.php

@@ -44,12 +44,12 @@ public function conformsToDefinition(mixed $value)
     {
         // check if null
         if ($value === null) {
+            // optional parameters can be null
             if (!$this->required) {
-                ///TODO: what if a required param can be null? Does that mean that required & null is fine? How to check the required constrains then?
-                //throw new InvalidArgumentException($this->name, "The parameter is required and cannot be null.");
                 return true;
             }
 
+            // required parameters can be null only if explicitly nullable
             if (!$this->nullable) {
                 throw new InvalidArgumentException(
                     $this->name,
@@ -92,9 +92,10 @@ public function toAnnotationParameterData()
             );
         }
 
-        $swaggerType = "string";
+        // determine swagger type
         $nestedArraySwaggerType = null;
         $swaggerType = $this->validators[0]::SWAGGER_TYPE;
+        // extract array element type
         if ($this->validators[0] instanceof VArray) {
             $nestedArraySwaggerType = $this->validators[0]->getElementSwaggerType();
         }
@@ -105,7 +106,6 @@ public function toAnnotationParameterData()
             $exampleValue = $this->validators[0]->getExampleValue();
         }
 
-        ///TODO: does not pass null
         return new AnnotationParameterData(
             $swaggerType,
             $this->name,

app/helpers/Swagger/AnnotationHelper.php

@@ -2,6 +2,7 @@
 
 namespace App\Helpers\Swagger;
 
+use App\Exceptions\InvalidArgumentException;
 use App\Helpers\MetaFormats\MetaFormatHelper;
 use App\V1Module\Router\MethodRoute;
 use App\V1Module\RouterFactory;
@@ -113,7 +114,7 @@ private static function getSwaggerType(string $annotationType): string
             }
 
             if (self::$typeMap[$typename] === null) {
-                throw new \InvalidArgumentException("Error in getSwaggerType: Unknown typename: {$typename}");
+                throw new InvalidArgumentException("Error in getSwaggerType: Unknown typename: {$typename}");
             }
 
             $type = self::$typeMap[$typename];
@@ -161,7 +162,7 @@ private static function extractStandardAnnotationParams(array $annotations, stri
                 $swaggerType = self::getSwaggerType($annotationType);
                 $nullable = self::isDatatypeNullable($annotationType);
 
-                ///TODO: how to find out the correct query type?
+                // the array element type cannot be determined from standard @param annotations
                 $nestedArraySwaggerType = null;
 
                 $descriptor = new AnnotationParameterData(