Skip to content

Commit 72b78c9

Browse files
adding an atime test case; groupby with dogroups (R expression) #PR4558 (#6288)
Co-authored-by: Toby Dylan Hocking <tdhock5@gmail.com>
1 parent b3c24a6 commit 72b78c9

1 file changed

Lines changed: 19 additions & 2 deletions

File tree

.ci/atime/tests.R

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,24 @@ test.list <- atime::atime_test_list(
121121
Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801)
122122
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)
123123

124+
# Issue reported in: https://github.com/Rdatatable/data.table/issues/4200
125+
# To be fixed in: https://github.com/Rdatatable/data.table/pull/4558
126+
"DT[by] fixed in #4558" = atime::atime_test(
127+
N = 10^seq(1, 20),
128+
setup = {
129+
d <- data.table(
130+
id3 = sample(c(seq.int(N*0.9), sample( N*0.9, N*0.1, TRUE))),
131+
v1 = sample(5L, N, TRUE),
132+
v2 = sample(5L, N, TRUE)
133+
)
134+
},
135+
expr = {
136+
expr=data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id3)
137+
},
138+
Before = "7a9eaf62ede487625200981018d8692be8c6f134", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/515de90a6068911a148e54343a3503043b8bb87c) in the PR (https://github.com/Rdatatable/data.table/pull/4164/commits) that introduced the regression
139+
Regression = "c152ced0e5799acee1589910c69c1a2c6586b95d", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/15f0598b9828d3af2eb8ddc9b38e0356f42afe4f) in the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
140+
Fixed = "f750448a2efcd258b3aba57136ee6a95ce56b302"), # Second commit of the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
141+
124142
# Issue with sorting again when already sorted: https://github.com/Rdatatable/data.table/issues/4498
125143
# Fixed in: https://github.com/Rdatatable/data.table/pull/4501
126144
"DT[,.SD] improved in #4501" = atime::atime_test(
@@ -136,8 +154,7 @@ test.list <- atime::atime_test_list(
136154
},
137155
Fast = "353dc7a6b66563b61e44b2fa0d7b73a0f97ca461", # Close-to-last merge commit in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
138156
Slow = "3ca83738d70d5597d9e168077f3768e32569c790", # Circa 2024 master parent of close-to-last merge commit (https://github.com/Rdatatable/data.table/commit/353dc7a6b66563b61e44b2fa0d7b73a0f97ca461) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
139-
Slower = "cacdc92df71b777369a217b6c902c687cf35a70d" # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
140-
),
157+
Slower = "cacdc92df71b777369a217b6c902c687cf35a70d"), # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
141158

142159
NULL)
143160
# nolint end: undesirable_operator_linter.

0 commit comments

Comments
 (0)