fix: Prevent mocha tests failures when window does not have focus. #9332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Aug 27, 2025
gonfunko
added a commit
that referenced
this pull request
Aug 28, 2025
…9332) * chore: Add puppeteer-core as a dev dependency. * fix: Make mocha tests run in a fake-focused window. * fix: Make `test:mocha:interactive` use the same gulp codepath as `test`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8937
Proposed Changes
This PR uses the Chrome devtools "Emulate a focused page" option to make the window that the Mocha tests run in always behave as if it is focused, regardless of whether or not it actually does in the window manager/OS. This makes the test environment more consistent and prevents intermittent flakes based on the window having focus or not. Additionally, the
test:mocha:interactivecommand has been updated to use the same Gulp codepath as thetestcommand; previously, it just opened a window, but didn't run the code that configured Webdriver/Chrome options.