fix: Fix bug that caused inadvertent scrolling when the WidgetDiv was shown.
#9291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
requested changes
Aug 12, 2025
Collaborator
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! This makes sense. I had a couple of thoughts--PTAL.
maribethb
reviewed
Aug 13, 2025
BenHenning
approved these changes
Aug 14, 2025
Collaborator
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @gonfunko! Approving to unblock, though I did leave one comment just to double check that the test fails as expected.
gonfunko
added a commit
that referenced
this pull request
Aug 28, 2025
…as shown. (#9291) * fix: Fix bug that caused inadvertent scrolling when the `WidgetDiv` was shown. * chore: Add test to verify that displaying the context menu does not scroll the page. * chore: Clarify comments. * fix: Remove errant `.only`. * chore: Add test to verify that actively focusing a node does not scroll the page. * fix: Remove inadvertent `.only`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9246
Proposed Changes
This PR updates the
FocusManagerto not automatically scroll focused nodes into view (the default browser behavior). This was causing shifts in the top-level page when theWidgetDivwas shown, and may have caused inadvertent scrolling in other contexts as well.