refactor: Associate comment bar buttons with the comment view. #9278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7a61ec to
b15c73b
Compare
maribethb
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This PR refactors the recently-introduced comment bar button classes to be associated with the
CommentViewthey are hosted in rather than theRenderedWorkspaceCommentthat theCommentView(may) be associated with. This was driven by Scratch, which usesCommentViewto display block comments in addition to workspace comments, and thus has noRenderedWorkspaceCommentinstance associated with them. Many other services also use workspace comment-styled block comments which may benefit from reusingCommentViewif they do not already.Breaking Change
This PR removes
CommentBarButton.getParentComment()and changes the constructor (and that of the two concrete subclasses) to take aCommentViewinstance. The former can be replaced byworkspace.getCommentById(barButton.getCommentView().commentId), if the comment bar button in question is actually associated with a comment view in aRenderedWorkspaceComment.