feat: Run keyboard plugin tests in CI #9135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The new tests may be slightly flaky and require some occasional re-runs. Probably still work introducing them in CI even with that. |
Collaborator
Author
|
/cc @rachel-fenichel and @maribethb as well in case you have strong opinions on this. If everyone's happy with it, feel free to merge while I'm out. |
RoboErikG
approved these changes
Jun 13, 2025
Contributor
RoboErikG
left a comment
There was a problem hiding this comment.
@maribethb @rachel-fenichel the config LGTM, but up to you if you want to submit today or leave for next week.
maribethb
approved these changes
Jun 18, 2025
af4a4b4
into
RaspberryPiFoundation:develop
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
N/A (no tracking issue)
Proposed Changes
Introduces a GitHub actions CI workflow to run the webdriver IO tests from https://github.com/google/blockly-keyboard-experimentation as part of core Blockly's CI.
Reason for Changes
Since development on the plugin is going to continue for many months yet, this ensures that behavioral changes in core Blockly don't inadvertently break the plugin.
Note that this shouldn't be made a blocking workflow since there may be cases where it's necessary to break the plugin before a change to the plugin itself can be introduced to then fix it (as this has happened many times in the past). However, the CI check is forced signal to both author and reviewer as to whether their change affects the plugin without having to manually check the test suite.
Test Coverage
N/A -- Verifying that the CI workflow runs is sufficient.
Documentation
No documentation changes are needed here.
Additional Information
Nothing.