fix!: Redundant blockly non selectable #8328 #8433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility into existing classes
…lectability into existing classes RaspberryPiFoundation#8328
…lectability into existing classes RaspberryPiFoundation#8328
…lectability into existing classes RaspberryPiFoundation#8328
…lectability into existing classes RaspberryPiFoundation#8328
1 task
Contributor
Author
|
@BeksOmega please review! this is the new PR for #8328 , on the correct branch |
BeksOmega
reviewed
Jul 30, 2024
Contributor
BeksOmega
left a comment
There was a problem hiding this comment.
One comment! And could you also run npm run format in the root directory of the repository and commit your changes?
core/menu.ts
Outdated
Comment on lines
87
to
88
| // goog-menu is deprecated, use blocklyMenu. May 2020. | ||
| element.className = 'blocklyMenu goog-menu'; |
Contributor
There was a problem hiding this comment.
Looks like you might have picked up an old change in your rebase, could you remove the goog-menu class and the comment from here?
Suggested change
| // goog-menu is deprecated, use blocklyMenu. May 2020. | |
| element.className = 'blocklyMenu goog-menu'; | |
| element.className = 'blocklyMenu'; |
Contributor
Author
|
Sure! |
…lectability into existing classes RaspberryPiFoundation#8328
…lectability into existing classes
59de2fe to
d4ddb18
Compare
Contributor
Author
|
I have made all the changes, and also ran |
BeksOmega
approved these changes
Jul 30, 2024
Contributor
BeksOmega
left a comment
There was a problem hiding this comment.
Sweet thank you for the fixes! This looks great =)
Contributor
Author
|
Thanks @BeksOmega! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Basics
The Details
The pull request removes redundant
blocklyNonSelectableclass and integrated non-selectability into existing and more generic classesResolves
Fixes #8328