Adds remove methods for all API classes#347
Merged
Merged
Conversation
StephenNneji
approved these changes
Feb 17, 2025
|
|
||
| obj.varTable(row, :) = []; | ||
|
|
||
| indices = sort(indices, 'descend'); |
Collaborator
There was a problem hiding this comment.
Since the indices are sorted here, the sort on line 60 is not needed. Also the for loop below is not needed since indices is sorted.
Collaborator
Author
There was a problem hiding this comment.
If the input is a cell array of multiple row names, the resulting indices array will not be sorted, so it is needed here. There's also no guarantee that a list of rows provided is valid so I think the for loop is still needed too.
Collaborator
Author
There was a problem hiding this comment.
Ahh, sorry. Misread here. I'll take out the sort on line 60 too.
| end | ||
| end | ||
|
|
||
| obj.varTable(indices, :) = []; |
Collaborator
There was a problem hiding this comment.
This line should work with unsorted indices so maybe the sort can be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #340