-
Notifications
You must be signed in to change notification settings - Fork 19
setup(esm): put it as first #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think we should move much less files. Otherwise it will be really bad in bigger packages. |
Why not merge this pr with the proof that CJS works, then do the following which removes the CJS test now on npmjs: unpacked size 34.3 kB |
|
If we have to move so many files then I would say it doesn't work and we shouldn't migrate |
AH you mean moving to mod, src ... ? we can do without bu IMO it's will be better in term of maintainability |
|
Most of the changes here are unnecessary. Simply changing module.export with export keyword should be all that's needed |
The idea of having main mod on ESM is to allowing JSR publish (REF discord discussion) |
|
Unless that doesn't support npm packages, I don't understand the comment |
Could you rephrase your idea because I didn't get it |
|
Can you change this PR so that it modifies the minimal amount of files and moves none ? |
|
I can ofc |
|
looks like this specific module has already been supporting esm since 2021 #17 |
Yes, but no, the idea here is to put the esm first. As a reminder, the ultimate goal is to publish packages on JSR in order to move forward with the JS ecosystem. |
Co-authored-by: Joyee Cheung <[email protected]>
|
@rom1504 ready ? |
|
cc @rom1504 |
Note
That's an experiment so it's may not be merged