test(rpc): add comprehensive test suite for platform-rpc module

[cuteolaf]

Summary by CodeRabbit

• Tests
  • Expanded test coverage for RPC server authentication, handlers, JSON-RPC functionality, server lifecycle, and data types. All changes are internal testing enhancements with no impact to user-facing functionality.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Comprehensive unit test coverage additions across five RPC server modules—authentication, handlers, JSON-RPC, server, and types. All changes are test-only, covering edge cases, error paths, and normal operations without modifying production logic or public APIs.

Changes

Cohort / File(s)	Summary
RPC Server Test Coverage Expansion crates/rpc-server/src/auth.rs, crates/rpc-server/src/handlers.rs, crates/rpc-server/src/jsonrpc.rs, crates/rpc-server/src/server.rs, crates/rpc-server/src/types.rs	Comprehensive unit tests added across all modules (1,733 lines total). Tests cover authentication logic (signature verification, timestamps), handler behaviors (registration, heartbeat, jobs, epochs), JSON-RPC operations (validators, challenges, pagination), server lifecycle, and type serialization. All tests exercised via cfg(test) blocks; no runtime logic changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Hops through the tests with glee and cheer,
Eight-hundred thirty-three cases dear!
Edge cases caught, errors found,
Quality code all around!
No bugs can hide from this thorough test spree!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the pull request as adding a comprehensive test suite for the RPC module, which matches the changes across all five files that add extensive unit tests.
Docstring Coverage	✅ Passed	Docstring coverage is 99.12% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 138fbf9 and 55fc570.

📒 Files selected for processing (5)

• crates/rpc-server/src/auth.rs
• crates/rpc-server/src/handlers.rs
• crates/rpc-server/src/jsonrpc.rs
• crates/rpc-server/src/server.rs
• crates/rpc-server/src/types.rs

🧰 Additional context used

🧬 Code graph analysis (1)

crates/rpc-server/src/server.rs (2)

crates/rpc-server/src/handlers.rs (1)

• new (29-45)

crates/rpc-server/src/jsonrpc.rs (4)

• new (210-224)
• error (115-126)
• result (106-113)
• name (243-248)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Test

🔇 Additional comments (6)

crates/rpc-server/src/types.rs (1)

379-517: LGTM! Excellent test coverage for RPC types.

The test suite comprehensively covers serialization/deserialization and basic field validation for all major RPC data structures. The tests are well-structured and verify:

• RpcResponse ok/error constructors work correctly
• All request/response types properly serialize to/from JSON
• Field values are preserved through serde round-trips
• Edge cases like accepted/rejected registration responses

crates/rpc-server/src/auth.rs (1)

100-174: LGTM! Comprehensive authentication edge case coverage.

The test suite thoroughly exercises authentication logic including:

• Invalid hotkey and signature formats
• Signature verification with mismatched hotkey/message
• Timestamp validation at boundary conditions (exactly 300 seconds, future timestamps)
• Signature length validation (too short/too long)

The timestamp edge case tests (lines 146-158) are particularly well-designed, testing both past and future timestamps at the boundary thresholds.

crates/rpc-server/src/jsonrpc.rs (1)

1942-2676: LGTM! Exceptionally comprehensive JSON-RPC test coverage.

This test suite is outstanding in its thoroughness, covering:

• All major RPC method namespaces (system, chain, state, validator, metagraph, challenge, job, epoch, monitor, sudo)
• Error handling with correct error codes (INVALID_PARAMS, CHALLENGE_NOT_FOUND, JOB_NOT_FOUND, VALIDATOR_NOT_FOUND)
• Pagination and filtering scenarios
• Challenge route registration, unregistration, and lookup (by ID and name)
• Helper functions like normalize_challenge_name
• Edge cases like empty parameters, invalid formats, missing data

The tests are well-isolated, each creating its own mock state, ensuring no test dependencies or side effects.

crates/rpc-server/src/handlers.rs (1)

483-1152: LGTM! Comprehensive handler test coverage with excellent error path testing.

This test suite excels in covering both success and failure scenarios for all RPC handlers:

• Registration flow: Tests invalid signatures, banned validators, already registered cases, invalid hotkey formats, and full capacity scenarios (lines 666-1024)
• Heartbeat: Tests invalid hotkey, unregistered validators, and successful updates including peer_id propagation (lines 750-804)
• Job results: Tests invalid job IDs, invalid signatures, not found cases, and successful state updates (lines 845-1086)
• Epoch phases: Tests all three phases (evaluation, commit, reveal) with correct block height calculations (lines 886-917)
• Weight commit/reveal: Tests both invalid signature rejection and successful submission (lines 931-1151)

The tests properly verify state mutations (e.g., lines 745-746 check validator was added; lines 1083-1085 verify job status updated to Completed).

crates/rpc-server/src/server.rs (2)

559-559: Minor import addition for tests.

Import of serde_json::json macro is only used in test code.

---

584-693: LGTM! Complete server lifecycle and request handling tests.

The test suite covers essential server functionality:

• Server creation and accessors: Tests rpc_handler() returns correct handler with expected netuid, and addr() returns configured address (lines 584-619)
• Request handling edge cases:
  • Invalid JSON structure (missing required fields) correctly returns PARSE_ERROR (lines 622-636)
  • Invalid JSON-RPC version ("1.0" instead of "2.0") is properly rejected (lines 639-657)
  • Valid requests return OK with result data (lines 660-678)
• Config customization: Verifies all config fields (addr, netuid, name, min_stake, cors_enabled) are properly stored (lines 681-693)

The tests properly exercise the handle_single_request function which is central to JSON-RPC request processing.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}