Merge #2969: [GUI] Update PIVX Shield Logos

50f8701 Build: Remove no longer used old splash images (Fuzzbawls)
3ed1974 GUI: Update PIVX Shield Logos (Fuzzbawls)

Pull request description:

  Updates the various images/icons that use the PIVX Shield logo to the newer design. Also removes the unused (since v5.0) old splash images.

  Note: the animated "processing" images will be a separate PR.

ACKs for top commit: 50f8701
  Duddino:
    ACK 50f8701
  Liquid369:
    tACK 50f8701

Tree-SHA512: 205262381ce8fc4a546095beff5a25ad127862d822af2fae99d8246aee5e392bd1f134284bf24f7ef956233403fe7283c968f60b3be6dfe72b26c976b74961f6

Author: Fuzzbawls

build-aux/snap/snapcraft.yaml

@@ -124,7 +124,6 @@ parts:
       COPYCONF=0    # copy example config into users data folder, 1 = enabled
       JOBS=4        # 0 means off and make will run without -j
       PATCH=1       # 1 = enabled
-      SPLASHPNGS=0  # patch pngs to differ visaully from those installed from self compilation or other source like deb
       FIXPPCBUILD=1 # if ppc builds fail due to failed qt, apps part will return error and build will fail, 1 = enabled
       EXTRALOG=0    # prints env and all installed files at the end of current script
       RUNTESTS=0    # run make check after post install part
@@ -173,20 +172,6 @@ parts:
       else
         echo "APPLY .patch files during compilation is disabled, skipping"
       fi
-      if [ $SPLASHPNGS = 1 ]; then
-        echo "replace splash screen with snapcrafts"
-        mv -f $SNAPCRAFT_PART_BUILD/contrib/snap/images/splash.png $SNAPCRAFT_PART_BUILD/src/qt/res/images/splash.png
-        mv -f $SNAPCRAFT_PART_BUILD/contrib/snap/images/splash_regtest.png $SNAPCRAFT_PART_BUILD/src/qt/res/images/splash_regtest.png
-        mv -f $SNAPCRAFT_PART_BUILD/contrib/snap/images/splash_testnet.png $SNAPCRAFT_PART_BUILD/src/qt/res/images/splash_testnet.png
-        mv -f $SNAPCRAFT_PART_BUILD/contrib/snap/icons/favicon.ico $SNAPCRAFT_PART_BUILD/share/pixmaps/favicon.ico
-        mv -f $SNAPCRAFT_PART_BUILD/contrib/snap/icons/favicon_testnet.ico $SNAPCRAFT_PART_BUILD/share/pixmaps/favicon_testnet.ico
-        mv -f $SNAPCRAFT_PART_BUILD/contrib/snap/icons/favicon_regtest.ico $SNAPCRAFT_PART_BUILD/share/pixmaps/favicon_regtest.ico
-        mv -f $SNAPCRAFT_PART_BUILD/build-aux/snap/local/desktop/${BINPREF}.png $SNAPCRAFT_PART_BUILD/src/qt/res/icons/${BINPREF}.png
-        mv -f $SNAPCRAFT_PART_BUILD/build-aux/snap/local/desktop/${BINPREF}_testnet.png $SNAPCRAFT_PART_BUILD/src/qt/res/icons/${BINPREF}_testnet.png
-        mv -f $SNAPCRAFT_PART_BUILD/build-aux/snap/local/desktop/${BINPREF}_regtest.png $SNAPCRAFT_PART_BUILD/src/qt/res/icons/${BINPREF}_regtest.png
-      else
-        echo "patch icons and images is disabled, skipping"
-      fi
       if [ $DEPENDS = 1 ]; then
         echo "-----------------------------------------------"
         echo "+++++++++++++++++++++++++++++++++++++++++++++++"