Simplify Audio Processing (remove ugly loops) #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…convert sample values into floats (AV_SAMPLE_FMT_FLTP), each channel in it's own data buffer, which makes it easy to pass to Frame::AddAudio.
Member
Author
…exity. Most codecs handle the multi-tasking themselves, making this code mostly useless.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #938 +/- ##
===========================================
+ Coverage 54.11% 54.19% +0.08%
===========================================
Files 182 182
Lines 16711 16925 +214
===========================================
+ Hits 9043 9173 +130
- Misses 7668 7752 +84 ☔ View full report in Codecov by Sentry. |
…ng audio trailer, etc...
…simplicity. Increasing margin on webm unit tests, when checking pixel color.
…e upgraded OpenCV and Protobuf, and this has introduced a crash.
…). Disabling GitHub windows builders for now - since they are using bleeding edge opencv and protobuf, which is incompatible with my old Cmake and old Opencv installs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert sample values into floats (AV_SAMPLE_FMT_FLTP), each channel in it's own data buffer, which makes it easy to pass to Frame::AddAudio. Then, let's utilize the FLTP format as much as possible, to avoid ugly nested loops converting audio sample formats. The primary goal of this PR is to massively simplify audio processing.