Skip to content

Conversation

@jeffski
Copy link
Contributor

@jeffski jeffski commented May 7, 2023

It looks like QtTextReader and QtHtmlReader were omitted when the GetSamplePerFrame functionality was added to other readers. Without the sample_count bad things happen to the audio, see: #913

This fix adds the same functionality, copied from the QtImageReader, to get the sample_count, and the audio issues reported in #913 seem to be resolved.

@jeffski
Copy link
Contributor Author

jeffski commented May 15, 2023

This also seems to resolve issue #914

@jeffski
Copy link
Contributor Author

jeffski commented May 24, 2023

Does libopenshot build in Ubuntu 22. I upgraded the other day and I am getting an error with libavresample. Looks like this build is having the same issue:

-- Found FFmpeg: /usr/lib/x86_64-linux-gnu/libavcodec.so;/usr/lib/x86_64-linux-gnu/libavformat.so;/usr/lib/x86_64-linux-gnu/libavutil.so;/usr/lib/x86_64-linux-gnu/libswscale.so;/usr/lib/x86_64-linux-gnu/libswresample.so (found version "4.4.2-0ubuntu0.22.04.1") found components: avcodec avformat avutil swscale swresample missing components: avresample

I'm not sure if libavresample is available for Ubuntu 22.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #926 (3b0f1d2) into develop (8ab0cb4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #926      +/-   ##
===========================================
- Coverage    53.66%   53.63%   -0.03%     
===========================================
  Files          182      182              
  Lines        16829    16837       +8     
===========================================
  Hits          9031     9031              
- Misses        7798     7806       +8     
Impacted Files Coverage Δ
src/Fraction.cpp 96.77% <0.00%> (ø)
src/QtHtmlReader.cpp 0.00% <0.00%> (ø)
src/QtTextReader.cpp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph
Copy link
Member

jonoomph commented Jun 2, 2023

Thanks! LGTM. I reran the checks and they succeeded. Not sure why they initially failed.

@jonoomph jonoomph merged commit b1104d8 into OpenShot:develop Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants