Raise preview cache to CPUs*8 frames, max 64 #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #416 +/- ##
========================================
Coverage 42.37% 42.37%
========================================
Files 129 129
Lines 13276 13276
========================================
Hits 5626 5626
Misses 7650 7650
Continue to review full report at Codecov.
|
This was referenced Jan 20, 2020
Member
|
LGTM! |
jonoomph
added a commit
that referenced
this pull request
Feb 7, 2020
… not see any crazy memory demands from this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on my 4-core, far from high-performance system, the effect this has on playback stuttering and smoothness is immense.
With a 32-frame cache, even with debug logging enabled the preview is largely smooth, at least when playing a Timeline with a single, unedited clip on it. With only 8 frames of buffer to work with, playback is jerky and stuttering even in that simple, best-case scenario.