Skip to content

Commit c04dc94

Browse files
authored
Wrap assignment in conditional with () (#379)
1 parent 5e1b6fd commit c04dc94

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Clip.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,7 @@ void Clip::SetJsonValue(Json::Value root) {
914914

915915
if (!existing_effect["type"].isNull()) {
916916
// Create instance of effect
917-
if (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) {
917+
if ( (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) ) {
918918

919919
// Load Json into Effect
920920
e->SetJsonValue(existing_effect);

src/Timeline.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,7 +1098,7 @@ void Timeline::SetJsonValue(Json::Value root) {
10981098

10991099
if (!existing_effect["type"].isNull()) {
11001100
// Create instance of effect
1101-
if (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) {
1101+
if ( (e = EffectInfo().CreateEffect(existing_effect["type"].asString())) ) {
11021102

11031103
// Load Json into Effect
11041104
e->SetJsonValue(existing_effect);
@@ -1364,7 +1364,7 @@ void Timeline::apply_json_to_effects(Json::Value change, EffectBase* existing_ef
13641364
EffectBase *e = NULL;
13651365

13661366
// Init the matching effect object
1367-
if (e = EffectInfo().CreateEffect(effect_type)) {
1367+
if ( (e = EffectInfo().CreateEffect(effect_type)) ) {
13681368

13691369
// Load Json into Effect
13701370
e->SetJsonValue(change["value"]);

0 commit comments

Comments
 (0)