Skip to content

Commit 6b9a9ca

Browse files
committed
Removed the branch for low fixed bitrate q values as it did not
work with mpeg2 export. Now for low fixed bitrates no presets for the q values are set. TODO find the optimum q values for each codec for low and high bitrates
1 parent 6a21c98 commit 6b9a9ca

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/FFmpegWriter.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,10 +1136,8 @@ AVStream* FFmpegWriter::add_video_stream()
11361136
c->qmin = 2;
11371137
c->qmax = 30;
11381138
}
1139-
else {
1140-
c->qmin = 0;
1141-
c->qmax = 63;
1142-
}
1139+
// Here should be the setting for low fixed bitrate
1140+
// Defaults are used because mpeg2 otherwise had problems
11431141
}
11441142
else {
11451143
c->qmin = 0;
@@ -1153,8 +1151,6 @@ AVStream* FFmpegWriter::add_video_stream()
11531151
//c->rc_buffer_size = FFMAX(c->rc_max_rate, 15000000) * 112L / 15000000 * 16384;
11541152
//if ( !c->rc_initial_buffer_occupancy )
11551153
// c->rc_initial_buffer_occupancy = c->rc_buffer_size * 3/4;
1156-
// c->qmin = 2;
1157-
// c->qmax = 30;
11581154

11591155
/* resolution must be a multiple of two */
11601156
// TODO: require /2 height and width

0 commit comments

Comments
 (0)