Always catch-by-reference in C++11

ferdnyc · ferdnyc · commit 25b522589ddf · 2019-07-03T12:58:02.000-04:00
diff --git a/src/CacheDisk.cpp b/src/CacheDisk.cpp
@@ -522,7 +522,7 @@ void CacheDisk::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/CacheMemory.cpp b/src/CacheMemory.cpp
@@ -377,7 +377,7 @@ void CacheMemory::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/ChunkReader.cpp b/src/ChunkReader.cpp
@@ -121,7 +121,7 @@ void ChunkReader::load_json()
 		info.audio_timebase.den = root["audio_timebase"]["den"].asInt();
 
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON could not be parsed (or is invalid).", path);
@@ -235,7 +235,7 @@ std::shared_ptr<Frame> ChunkReader::GetFrame(int64_t requested_frame)
 			local_reader = new FFmpegReader(chunk_video_path);
 			local_reader->Open(); // open reader
 
-		} catch (InvalidFile)
+		} catch (const InvalidFile& e)
 		{
 			// Invalid Chunk (possibly it is not found)
 			throw ChunkNotFound(path, requested_frame, location.number, location.frame);
@@ -298,7 +298,7 @@ void ChunkReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/Clip.cpp b/src/Clip.cpp
@@ -123,7 +123,7 @@ void Clip::init_reader_rotation() {
 		try {
 			float rotate_metadata = strtof(reader->info.metadata["rotate"].c_str(), 0);
 			rotation = Keyframe(rotate_metadata);
-		} catch (exception e) {}
+		} catch (const std::exception& e) {}
 	}
 	else
 		// Default no rotation
@@ -809,7 +809,7 @@ void Clip::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/Color.cpp b/src/Color.cpp
@@ -125,7 +125,7 @@ void Color::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/Coordinate.cpp b/src/Coordinate.cpp
@@ -88,7 +88,7 @@ void Coordinate::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/DecklinkReader.cpp b/src/DecklinkReader.cpp
@@ -283,7 +283,7 @@ void DecklinkReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/DummyReader.cpp b/src/DummyReader.cpp
@@ -161,7 +161,7 @@ void DummyReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/EffectBase.cpp b/src/EffectBase.cpp
@@ -117,7 +117,7 @@ void EffectBase::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/FFmpegReader.cpp b/src/FFmpegReader.cpp
@@ -2439,7 +2439,7 @@ void FFmpegReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e) {
+	catch (const std::exception& e) {
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
 	}
diff --git a/src/FrameMapper.cpp b/src/FrameMapper.cpp
@@ -712,7 +712,7 @@ void FrameMapper::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/ImageReader.cpp b/src/ImageReader.cpp
@@ -67,7 +67,7 @@ void ImageReader::Open()
 			image->backgroundColor(Magick::Color("none"));
 			MAGICK_IMAGE_ALPHA(image, true);
 		}
-		catch (Magick::Exception e) {
+		catch (const Magick::Exception& e) {
 			// raise exception
 			throw InvalidFile("File could not be opened.", path);
 		}
@@ -174,7 +174,7 @@ void ImageReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/KeyFrame.cpp b/src/KeyFrame.cpp
@@ -200,7 +200,7 @@ Point Keyframe::GetPreviousPoint(Point p) {
 		else
 			return Points[0];
 
-	} catch (OutOfBoundsPoint) {
+	} catch (const OutOfBoundsPoint& e) {
 		// No previous point
 		return Point(-1, -1);
 	}
@@ -384,7 +384,7 @@ void Keyframe::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/Point.cpp b/src/Point.cpp
@@ -151,7 +151,7 @@ void Point::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/Profiles.cpp b/src/Profiles.cpp
@@ -120,7 +120,7 @@ Profile::Profile(string path) {
 		}
 
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing profile file
 		throw InvalidFile("Profile could not be found or loaded (or is invalid).", path);
@@ -182,7 +182,7 @@ void Profile::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/QtImageReader.cpp b/src/QtImageReader.cpp
@@ -304,7 +304,7 @@ void QtImageReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/TextReader.cpp b/src/TextReader.cpp
@@ -235,7 +235,7 @@ void TextReader::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/Timeline.cpp b/src/Timeline.cpp
@@ -1045,7 +1045,7 @@ void Timeline::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
@@ -1160,7 +1160,7 @@ void Timeline::ApplyJsonDiff(string value) {
 
 		}
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");
diff --git a/src/WriterBase.cpp b/src/WriterBase.cpp
@@ -214,7 +214,7 @@ void WriterBase::SetJson(string value) {
 		// Set all values that match
 		SetJsonValue(root);
 	}
-	catch (exception e)
+	catch (const std::exception& e)
 	{
 		// Error parsing JSON (or missing keys)
 		throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");

Original file line number	Diff line number	Diff line change
`@@ -522,7 +522,7 @@ void CacheDisk::SetJson(string value) {`
`522`	`522`	`// Set all values that match`
`523`	`523`	`SetJsonValue(root);`
`524`	`524`	`}`
`525`		`- catch (exception e)`
	`525`	`+ catch (const std::exception& e)`
`526`	`526`	`{`
`527`	`527`	`// Error parsing JSON (or missing keys)`
`528`	`528`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ void CacheMemory::SetJson(string value) {`
`377`	`377`	`// Set all values that match`
`378`	`378`	`SetJsonValue(root);`
`379`	`379`	`}`
`380`		`- catch (exception e)`
	`380`	`+ catch (const std::exception& e)`
`381`	`381`	`{`
`382`	`382`	`// Error parsing JSON (or missing keys)`
`383`	`383`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ void ChunkReader::load_json()`
`121`	`121`	`info.audio_timebase.den = root["audio_timebase"]["den"].asInt();`
`122`	`122`
`123`	`123`	`}`
`124`		`- catch (exception e)`
	`124`	`+ catch (const std::exception& e)`
`125`	`125`	`{`
`126`	`126`	`// Error parsing JSON (or missing keys)`
`127`	`127`	`throw InvalidJSON("JSON could not be parsed (or is invalid).", path);`
`@@ -235,7 +235,7 @@ std::shared_ptr<Frame> ChunkReader::GetFrame(int64_t requested_frame)`
`235`	`235`	`local_reader = new FFmpegReader(chunk_video_path);`
`236`	`236`	`local_reader->Open(); // open reader`
`237`	`237`
`238`		`- } catch (InvalidFile)`
	`238`	`+ } catch (const InvalidFile& e)`
`239`	`239`	`{`
`240`	`240`	`// Invalid Chunk (possibly it is not found)`
`241`	`241`	`throw ChunkNotFound(path, requested_frame, location.number, location.frame);`
`@@ -298,7 +298,7 @@ void ChunkReader::SetJson(string value) {`
`298`	`298`	`// Set all values that match`
`299`	`299`	`SetJsonValue(root);`
`300`	`300`	`}`
`301`		`- catch (exception e)`
	`301`	`+ catch (const std::exception& e)`
`302`	`302`	`{`
`303`	`303`	`// Error parsing JSON (or missing keys)`
`304`	`304`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ void Clip::init_reader_rotation() {`
`123`	`123`	`try {`
`124`	`124`	`float rotate_metadata = strtof(reader->info.metadata["rotate"].c_str(), 0);`
`125`	`125`	`rotation = Keyframe(rotate_metadata);`
`126`		`- } catch (exception e) {}`
	`126`	`+ } catch (const std::exception& e) {}`
`127`	`127`	`}`
`128`	`128`	`else`
`129`	`129`	`// Default no rotation`
`@@ -809,7 +809,7 @@ void Clip::SetJson(string value) {`
`809`	`809`	`// Set all values that match`
`810`	`810`	`SetJsonValue(root);`
`811`	`811`	`}`
`812`		`- catch (exception e)`
	`812`	`+ catch (const std::exception& e)`
`813`	`813`	`{`
`814`	`814`	`// Error parsing JSON (or missing keys)`
`815`	`815`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ void Color::SetJson(string value) {`
`125`	`125`	`// Set all values that match`
`126`	`126`	`SetJsonValue(root);`
`127`	`127`	`}`
`128`		`- catch (exception e)`
	`128`	`+ catch (const std::exception& e)`
`129`	`129`	`{`
`130`	`130`	`// Error parsing JSON (or missing keys)`
`131`	`131`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ void Coordinate::SetJson(string value) {`
`88`	`88`	`// Set all values that match`
`89`	`89`	`SetJsonValue(root);`
`90`	`90`	`}`
`91`		`- catch (exception e)`
	`91`	`+ catch (const std::exception& e)`
`92`	`92`	`{`
`93`	`93`	`// Error parsing JSON (or missing keys)`
`94`	`94`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ void DecklinkReader::SetJson(string value) {`
`283`	`283`	`// Set all values that match`
`284`	`284`	`SetJsonValue(root);`
`285`	`285`	`}`
`286`		`- catch (exception e)`
	`286`	`+ catch (const std::exception& e)`
`287`	`287`	`{`
`288`	`288`	`// Error parsing JSON (or missing keys)`
`289`	`289`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ void DummyReader::SetJson(string value) {`
`161`	`161`	`// Set all values that match`
`162`	`162`	`SetJsonValue(root);`
`163`	`163`	`}`
`164`		`- catch (exception e)`
	`164`	`+ catch (const std::exception& e)`
`165`	`165`	`{`
`166`	`166`	`// Error parsing JSON (or missing keys)`
`167`	`167`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ void EffectBase::SetJson(string value) {`
`117`	`117`	`// Set all values that match`
`118`	`118`	`SetJsonValue(root);`
`119`	`119`	`}`
`120`		`- catch (exception e)`
	`120`	`+ catch (const std::exception& e)`
`121`	`121`	`{`
`122`	`122`	`// Error parsing JSON (or missing keys)`
`123`	`123`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
Original file line number	Diff line number	Diff line change
`@@ -2439,7 +2439,7 @@ void FFmpegReader::SetJson(string value) {`
`2439`	`2439`	`// Set all values that match`
`2440`	`2440`	`SetJsonValue(root);`
`2441`	`2441`	`}`
`2442`		`- catch (exception e) {`
	`2442`	`+ catch (const std::exception& e) {`
`2443`	`2443`	`// Error parsing JSON (or missing keys)`
`2444`	`2444`	`throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");`
`2445`	`2445`	`}`