Merged
Conversation
…slightly refactor things to reduce copypasta
Member
|
👀 |
Member
thirtytwobits
left a comment
There was a problem hiding this comment.
Nothing staggering in my review but a few points I'd like to discuss.
…r to value semantics #sonar
| /// required context to compute the size, or if the memory resource implementation does not require deallocation size. | ||
| /// | ||
| /// The head of the fragment list is passed by value so it is not freed. This is in line with the UdpardRxTransfer | ||
| /// design, where the head is stored by value to reduce indirection in small transfers. We call it Scott's Head. |
thirtytwobits
approved these changes
Aug 8, 2023
Member
thirtytwobits
left a comment
There was a problem hiding this comment.
Only style feedback at this point.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the common parts of the RX pipeline. At this point, about 90% of the work is done. All that is left is to add the basic public API wrappers for subscriptions and RPC-services. For details about the implementation of the RX pipeline refer to the line that says "Internally, the RX pipeline is arranged as follows".
Slightly refactor the code added earlier to uphold orthogonality and avoid unnecessary duplication.
Trivial renamings to keep names shorter, e.g.:
UdpardConstPayload->UdpardPayload(const implied by default; there's alsoUdpardMutablePayload)UdpardPayloadFragmentHandle->UdpardFragmentEstablish an internal convention that functions named "Destroy" deallocate the passed memory while "Free" only deallocate the memory of the associated resources. This is not API-visible.
Remove the
port_idfield fromUdpardRxPortbecause it is not needed.After this is merged, the remaining task is to simply implement the public RX pipeline functions on top of:
rxPortInitrxPortAcceptFramerxPortFreeThe test coverage is supposed to be full but llvm-cov slightly misreports it.