-
Notifications
You must be signed in to change notification settings - Fork 70
Added support to import Sillytavern cards. #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… and a button is generated to choose a live2d model from the model_dict.yaml. Character\NAME.yaml is created. Requires a change to backend src/open_llm_vtuber/routes.py
Summary of ChangesHello @NBD-1138, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's character management capabilities by enabling direct import of SillyTavern character cards. It provides a dedicated dialog for users to upload either PNG or JSON card files, which are then processed to extract character details such as name, description, and personality. Users can preview the extracted information, select a Live2D model, and create a new character entry within the application, with an option to save embedded avatars from PNG cards. This feature simplifies the process of adding and configuring new characters, making the application more versatile for users who utilize external character card formats. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature to import SillyTavern character cards, which is a great addition. The implementation includes parsing logic for both .png and .json card formats, a new dialog for file selection, and integration into the settings UI. My review focuses on improving code maintainability by removing dead code and debug logs, fixing a bug related to a UI component prop, and addressing a couple of issues in the main logic hook, including a bug where a state flag is ignored and another where errors are silently swallowed. Overall, the changes are well-structured, and with these adjustments, the feature will be more robust and easier to maintain.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Card is placed in /avatar/ and a button is generated to choose a live2d model from the model_dict.yaml. Character\NAME.yaml is created. Requires a change to backend src/open_llm_vtuber/routes.py
PR for routes.py already up Open-LLM-VTuber/Open-LLM-VTuber#299