Skip to content

Conversation

@NBD-1138
Copy link

Card is placed in /avatar/ and a button is generated to choose a live2d model from the model_dict.yaml. Character\NAME.yaml is created. Requires a change to backend src/open_llm_vtuber/routes.py

PR for routes.py already up Open-LLM-VTuber/Open-LLM-VTuber#299

… and a button is generated to choose a live2d model from the model_dict.yaml. Character\NAME.yaml is created. Requires a change to backend src/open_llm_vtuber/routes.py
@gemini-code-assist
Copy link

Summary of Changes

Hello @NBD-1138, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's character management capabilities by enabling direct import of SillyTavern character cards. It provides a dedicated dialog for users to upload either PNG or JSON card files, which are then processed to extract character details such as name, description, and personality. Users can preview the extracted information, select a Live2D model, and create a new character entry within the application, with an option to save embedded avatars from PNG cards. This feature simplifies the process of adding and configuring new characters, making the application more versatile for users who utilize external character card formats.

Highlights

  • SillyTavern Card Import: Introduced functionality to import character cards from SillyTavern, supporting both ".png" and ".json" formats.
  • New UI Component: Added ImportCardDialog to provide a user interface for selecting card files, previewing character data, and choosing a Live2D model.
  • Character Card Parsing Logic: Implemented useImportCard hook to handle the complex parsing of character card data, including extracting embedded JSON from PNG files and decompressing Zlib-compressed chunks using the pako library.
  • Live2D Model Integration: Allows users to associate an imported character with an existing Live2D model from the application's model_dict.yaml.
  • Avatar Saving (PNG cards): For PNG character cards, the embedded avatar can optionally be saved and uploaded to the /avatar/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature to import SillyTavern character cards, which is a great addition. The implementation includes parsing logic for both .png and .json card formats, a new dialog for file selection, and integration into the settings UI. My review focuses on improving code maintainability by removing dead code and debug logs, fixing a bug related to a UI component prop, and addressing a couple of issues in the main logic hook, including a bug where a state flag is ignored and another where errors are silently swallowed. Overall, the changes are well-structured, and with these adjustments, the feature will be more robust and easier to maintain.

NBD-1138 and others added 2 commits October 23, 2025 15:14
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant