Skip to content

Commit 09d6b8a

Browse files
authored
Merge pull request #98 from Nefariusek/bug/issue-97
Fixing paths and urls for the production version
2 parents 39899a2 + a0c8123 commit 09d6b8a

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

src/views/AdoptionPage/AdoptionPage.css

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,41 +60,41 @@
6060
}
6161

6262
.adoption-page .navigation-container .dog {
63-
background: linear-gradient(rgba(255, 255, 255, 0.3), rgba(255, 255, 255, 0.3)), url(./adoption-dog.jpg), no-repeat;
63+
background: linear-gradient(rgba(255, 255, 255, 0.3), rgba(255, 255, 255, 0.3)), url(../adoption-dog.jpg), no-repeat;
6464
background-size: 290px;
6565
background-position: center center;
6666
}
6767

6868
.adoption-page .navigation-container .dog:hover {
69-
background: linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0)), url(./adoption-dog.jpg), no-repeat;
69+
background: linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0)), url(../adoption-dog.jpg), no-repeat;
7070
background-size: 290px;
7171
background-position: center center;
7272
transform: scale(1.1);
7373
transition: ease-in-out all 0.4s;
7474
}
7575

7676
.adoption-page .navigation-container .cat {
77-
background: linear-gradient(rgba(255, 255, 255, 0.3), rgba(255, 255, 255, 0.3)), url(./adoption-cat.jpg), no-repeat;
77+
background: linear-gradient(rgba(255, 255, 255, 0.3), rgba(255, 255, 255, 0.3)), url(../adoption-cat.jpg), no-repeat;
7878
background-size: 290px;
7979
background-position: center center;
8080
}
8181

8282
.adoption-page .navigation-container .cat:hover {
83-
background: linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0)), url(./adoption-cat.jpg), no-repeat;
83+
background: linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0)), url(../adoption-cat.jpg), no-repeat;
8484
background-size: 290px;
8585
background-position: center center;
8686
transform: scale(1.1);
8787
transition: ease-in-out all 0.4s;
8888
}
8989

9090
.adoption-page .navigation-container .bird {
91-
background: linear-gradient(rgba(255, 255, 255, 0.3), rgba(255, 255, 255, 0.3)), url(./adoption-bird.jpg), no-repeat;
91+
background: linear-gradient(rgba(255, 255, 255, 0.3), rgba(255, 255, 255, 0.3)), url(../adoption-bird.jpg), no-repeat;
9292
background-size: 290px;
9393
background-position: center center;
9494
}
9595

9696
.adoption-page .navigation-container .bird:hover {
97-
background: linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0)), url(./adoption-bird.jpg), no-repeat;
97+
background: linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0)), url(../adoption-bird.jpg), no-repeat;
9898
background-size: 300px;
9999
background-position: center center;
100100
transform: scale(1.1);

src/views/AdoptionPage/AdoptionPage.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Button from '../../components/Button/Button';
33

44
const PAGE_TITLE = 'ADOPTION';
55
const MAIN_TEXT = 'CHOOSE YOUR NEW PET:';
6-
const MAIN_ANIMAL = { pathOrUrl: './bird.png', alt: 'flying bird' };
6+
const MAIN_ANIMAL = { pathOrUrl: '../bird.png', alt: 'flying bird' };
77
const ANIMAL_TYPES = [
88
{ type: 'cat', pathOrUrl: 'https://www.petfinder.com/' },
99
{ type: 'dog', pathOrUrl: 'https://www.petfinder.com/' },
@@ -43,7 +43,7 @@ function renderNavigation() {
4343

4444
ANIMAL_TYPES.forEach((animal) => {
4545
const animalOption = document.createElement('li');
46-
animalOption.innerHTML = `<a href="${animal.pathOrUrl}" class="option ${
46+
animalOption.innerHTML = `<a href="${animal.pathOrUrl}" target="_blank" class="option ${
4747
animal.type
4848
}"><span>${animal.type.toUpperCase()}</span></a>`;
4949
animalList.append(animalOption);

src/views/CreditsPage/CreditsPage.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Button from '../../components/Button/Button';
33
import Bubble from '../../components/Bubble/Bubble';
44

55
const PAGE_TITLE = 'CREDITS';
6-
const MAIN_ANIMAL_IMG = { pathOrUrl: './kangoroo.png', alt: 'kangoroo that tells informations' };
6+
const MAIN_ANIMAL_IMG = { pathOrUrl: '../kangoroo.png', alt: 'kangoroo that tells informations' };
77
const CreditsBubbleContent = {
88
HEADER_TEXT: 'This is our first project of Coders Camp 2021',
99
SENTENCE: 'Meet our whole team',

src/views/MainPage/MainPage.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { retrieveAnimalFact } from '../../api/FactsController';
66
import { onNavigationChange } from '../../components/router/Router';
77

88
const PAGE_TITLE = 'ANIMALIADA';
9-
const MAIN_ANIMAL_IMG = { pathOrUrl: './kangoroo.png', alt: 'kangoroo that tells informations' };
9+
const MAIN_ANIMAL_IMG = { pathOrUrl: '../kangoroo.png', alt: 'kangoroo that tells informations' };
1010
const FACT_HEADER = 'Did you know?';
1111
const AdoptionBubbleContent = {
1212
IMG: { pathOrUrl: 'https://placedog.net/150/150?random', alt: 'the animal to adoption' },
@@ -95,7 +95,6 @@ async function renderFactBubbleContent() {
9595
},
9696
false,
9797
);
98-
9998
renderAnimalFactImg(imageFact, imageObject);
10099
}
101100

0 commit comments

Comments
 (0)