Address coderabbit review

rg20 · rg20 · commit 53316968fb8e · 2026-04-01T11:20:19.000-07:00
diff --git a/cpp/src/dual_simplex/crossover.cpp b/cpp/src/dual_simplex/crossover.cpp
@@ -460,7 +460,7 @@ i_t dual_push(const lp_problem_t<i_t, f_t>& lp,
 
     // y <- y + step_length * delta_y
     // Optimized: Only update non-zero elements from sparse representation
-    for (i_t nnz_idx = 0; nnz_idx < delta_y_sparse.i.size(); ++nnz_idx) {
+    for (i_t nnz_idx = 0; nnz_idx < static_cast<i_t>(delta_y_sparse.i.size()); ++nnz_idx) {
       const i_t i = delta_y_sparse.i[nnz_idx];
       y[i] += step_length * delta_y_sparse.x[nnz_idx];
     }

Original file line number	Diff line number	Diff line change
`@@ -460,7 +460,7 @@ i_t dual_push(const lp_problem_t<i_t, f_t>& lp,`
`460`	`460`
`461`	`461`	`// y <- y + step_length * delta_y`
`462`	`462`	`// Optimized: Only update non-zero elements from sparse representation`
`463`		`- for (i_t nnz_idx = 0; nnz_idx < delta_y_sparse.i.size(); ++nnz_idx) {`
	`463`	`+ for (i_t nnz_idx = 0; nnz_idx < static_cast<i_t>(delta_y_sparse.i.size()); ++nnz_idx) {`
`464`	`464`	`const i_t i = delta_y_sparse.i[nnz_idx];`
`465`	`465`	`y[i] += step_length * delta_y_sparse.x[nnz_idx];`
`466`	`466`	`}`