Skip to content
This repository was archived by the owner on Dec 11, 2025. It is now read-only.

actually export the router when used as CommonJS module - #44

Merged
geekdave merged 1 commit into
geekdave:masterfrom
xMartin:actually-export
Oct 13, 2014
Merged

actually export the router when used as CommonJS module#44
geekdave merged 1 commit into
geekdave:masterfrom
xMartin:actually-export

Conversation

@xMartin

@xMartin xMartin commented Oct 13, 2014

Copy link
Copy Markdown
Contributor

When using backbone.subroute with browserify requiring it returns an empty object. I guess I could just use the export of the backbone module after requiring backbone.subroute but that is a bit ugly.

I want

var SubRouter = require('backbone.subroute');
var foo = SubRouter.extend({
   ...

@geekdave

Copy link
Copy Markdown
Owner

Looks good to me.

geekdave added a commit that referenced this pull request Oct 13, 2014
actually export the router when used as CommonJS module
@geekdave
geekdave merged commit 08c02cf into geekdave:master Oct 13, 2014
@geekdave

Copy link
Copy Markdown
Owner

Cut a new release with this fix: https://github.com/ModelN/backbone.subroute/releases/tag/0.4.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants