This repository was archived by the owner on Dec 11, 2025. It is now read-only.
Prepare module to be published to npm - #36
Merged
Conversation
geekdave
added a commit
that referenced
this pull request
Apr 7, 2014
Prepare module to be published to npm
Owner
|
Published here: https://www.npmjs.org/package/backbone.subroute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be really great if backbone.subroute was published on npm. I made all the necessary changes in order to make it work. If you need help, this doc should help you with pretty much everything. If you need any other help, I can probably answer any questions you have.
Changes:
.npmignoredependenciestodevDependencies(explained below)I moved backbone to
devDependenciesbecause backbone should always be a peer dependency. If you declare it, then something like browserify will require two separate backbones (one from their app, the other from your module), which you really don't want.If you need anything else in this PR, please let me know. Thanks