This repository was archived by the owner on Dec 11, 2025. It is now read-only.
Fix dynamic route add - #31
Closed
hellorachid wants to merge 1 commit into
Closed
Conversation
when a user doesn't create routes and he wanna add dynamic route subroute throw error because the varibale routes is undifined
example :
var browserModule = new Backbone.SubRoute("browser",{createTrailingSlashRoutes: true});
browserModule.route('browse',function(){console.log('browse');})
geekdave
added a commit
that referenced
this pull request
Dec 31, 2013
Owner
|
Thanks for the fix, @hellorachid ! I've merged it in a separate PR, since I needed to add a unit test for this case in order to get code coverage to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a user doesn't create routes and he wanna add dynamic route subroute throw error because the varibale routes is undifined
example :
var browserModule = new Backbone.SubRoute("browser",{createTrailingSlashRoutes: true});
browserModule.route('browse',function(){console.log('browse');})