Automatically indent "end" for ruby code

[philipgiuliani]

In VSCode 0.10.6 the "end" in ruby doesn't gets indented after writing it. It should be handled like the brackets in Javascript.

Left: VSCode, Right: Atom (Gif. Reload to see it again)

[markediez]

I'm guessing this will come in the next release?

[markediez]

Any update on this?

[kyleect]

+1 for this feature

[Tyriar]

@rebornix does your ruby extension do this?

[rebornix]

Firstly we have snippets in my ruby extension so each time you type def you will get correctly indented end. So it's likely a workaround.

Secondly, I think we have this auto indenting feature but unluckily I found it not working right now. I'll let you guys know when I have more info, then this issue can be treated as external.

[rebornix]

I'm trying to support correct indentation as Atom does, and find following interesting difference between VS Code, Atom and TextMate.

TextMate documents increaseIndentPattern and decreaseIndentPattern at https://manual.macromates.com/en/appendix . increaseIndentPattern matches a starting line and any lines after it will have an additional indentation, this functionality is handled correclty in all editors.

But when we come to decreaseIndentPattern, we are running into some problems. The documenation in TextMate site is not that clear, when a line matches decreaseIndentPattern regex, should we unindent the current line or lines after? IMHO, it should be current line as any previous line has additional indentation and it's the right time to unindent. This is also how Atom does it.

However, in our implementation as below

/**
  * Describes indentation rules for a language.
  */
export interface IndentationRule {
    /**
     * If a line matches this pattern, then all the lines after it should be unindendented once (until another rule matches).
     */
    decreaseIndentPattern: RegExp;

Per comments we put in the definition, we are unindenting lines after but not the current line. I'm not sure if it's the root cause, but this makes end never gets correct unindentation.

There is also a long bebate to add decreaseNextIndentPattern to Atom in atom/atom#6808 so I think we need to rethink what's the correct behavior of decreaseIndentPattern. I'll give TextMate a try once I'm back to my Mac to see what's the default behavior, before that I'd like to hear your voices. @alexandrudima , any thoughts?

[alexdima]

@rebornix I followed https://manual.macromates.com/en/appendix while implementing it.

I think I got wrong the semantics of decreaseIndentPattern (it should probably decrease the current line too).

The implementation is at https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/modes/supports/onEnter.ts#L128

To support decreasing the current line indent, the EnterAction must be extended with an additional type of IndentAction, a new one maybe called OutdentInclusive or something and it must be adopted everywhere where EnterAction is interpreted.

[coderberry]

Are there any updates on this? It's the one crutch for developing ruby apps using VS Code