Revert my file browser changes that affected search#8404
Conversation
|
Works, but I've noticed a few issues right off the bat: If I search for something, it automatically expands every folder where that is found and shows the results.
I suspect these are related, but isn't everything related in a codebase anyway? My suspicions are rather unfounded. Both issues can be observed in this recording: lmms_kmMq9GpGA2.mp4And obviously it crashes when searching in "My Computer" tab. I do have a suggestion: If any drive in the My Computer tab is expanded, search only that drive, else search only one directory deep. However, I don't know whether this is possible. Stable does something that enables searching drives, but it is too cursed for me to understand presently. |
Due to the unusual bugs that were reported as well as the recent backlash from users (there was also backlash when I did this previously), my plan is to revert my changes that affected search behavior in the file browser. I'm no longer confident in my ability to do this properly, but if anything, it serves as a clean slate for anyone who wants to improve on search the right way.
I tried to fix all the merge conflicts when doing the revert appropriately, but if some mistake slipped through, let me know.
PS: Searching in samples, projects, etc, might be slow/choppy, while searching in root and home will most likely freeze the application. This was the main issue, but hopefully it'll be fixed properly without backlash later if this is merged.
Fixes #8142
Fixes #8401