Fix sample track playback in pattern editor#8375
Open
Itreza2 wants to merge 3 commits into
Open
Conversation
bratpeki
approved these changes
May 20, 2026
Member
bratpeki
left a comment
There was a problem hiding this comment.
Approved for both code and testing!
yohannd1
suggested changes
May 20, 2026
Contributor
|
Tested and it seems to work fine! Demo vid: 2026-05-20.15-51-35.mp4I've found a bug which On this PR: 2026-05-20.15-51-51.mp4Applying 8369's changes on top of this, the behavior is the same, but the clip length is actually taken into account visually and it can be seen that the sample stops: 
|
Co-authored-by: Yohanan <23298480+yohannd1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4422
(this issue is tagged as enhancement, but I really see this as a bug fix)
Allow playback of a sample clip in the pattern editor to start at any position and not only at t=0 as it is currently the case.
This also ensure that the sample is played each loop, which is currently very inconsistent.