Skip to content

Conversation

@timholy
Copy link
Member

@timholy timholy commented Jan 12, 2021

This adds new tools that essentially attempt to shield users from having to deal with Cthulhu. Even for experts, this may speed the processing of long lists of inference triggers, by using automated tools that take a first pass at the triggers to determine if some can be discarded.

Test coverage for suggest is fairly poor, although that's a bit deliberate; I expect its recommendations to change a fair bit over time, and consequently I'm deferring detailed testing. suggest is explicitly marked as EXPERIMENTAL, and hence changes are viewed as non-breaking.

This this the last of the changes I anticipate before making a new release.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #214 (ae02f58) into master (096fdf5) will decrease coverage by 1.51%.
The diff coverage is 71.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   82.13%   80.62%   -1.52%     
==========================================
  Files           9        9              
  Lines        1125     1321     +196     
==========================================
+ Hits          924     1065     +141     
- Misses        201      256      +55     
Impacted Files Coverage Δ
src/SnoopCompile.jl 100.00% <ø> (ø)
src/parcel_snoopi_deep.jl 80.12% <71.85%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 096fdf5...ae02f58. Read the comment docs.

@timholy timholy force-pushed the teh/suggest branch 2 times, most recently from fa60ddc to 273adb0 Compare January 12, 2021 14:31
These new tools are designed to shield users from the complexity of Cthulhu.
It attempts to hint at a potential resolution, or in the case of test suites
short-circuit the need to do useless work analyzing inference triggers that
derive from the test suite itself.
@timholy timholy merged commit 8b0d781 into master Jan 12, 2021
@timholy timholy deleted the teh/suggest branch January 12, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants